Use positional instead of keyword arguments for EachLine

Author: pabloferz

base/deprecated.jl

@@ -1809,8 +1809,6 @@ eval(LibGit2, quote
     end
 end)
 
-@deprecate EachLine(stream, ondone) EachLine(stream, ondone=ondone)
-
 # These conversions should not be defined, see #19896
 @deprecate convert{T<:Number}(::Type{T}, x::Dates.Period) convert(T, Dates.value(x))
 @deprecate convert{T<:Dates.Period}(::Type{T}, x::Real)   T(x)

base/io.jl

@@ -543,7 +543,7 @@ type EachLine
     ondone::Function
     chomp::Bool
 
-    EachLine(stream::IO=STDIN; ondone::Function=()->nothing, chomp::Bool=true) =
+    EachLine(stream::IO=STDIN, ondone::Function=()->nothing, chomp::Bool=true) =
         new(stream, ondone, chomp)
 end
 
@@ -558,11 +558,11 @@ removed. When called with a file name, the file is opened once at the beginning
 iteration and closed at the end. If iteration is interrupted, the file will be
 closed when the `EachLine` object is garbage collected.
 """
-eachline(stream::IO=STDIN; chomp::Bool=true) = EachLine(stream, chomp=chomp)::EachLine
+eachline(stream::IO=STDIN; chomp::Bool=true) = EachLine(stream, ()->nothing, chomp)
 
 function eachline(filename::AbstractString; chomp::Bool=true)
     s = open(filename)
-    EachLine(s, ondone=()->close(s), chomp=chomp)::EachLine
+    EachLine(s, ()->close(s), chomp)
 end
 
 start(itr::EachLine) = nothing

base/process.jl

@@ -561,8 +561,8 @@ function eachline(cmd::AbstractCmd, stdin; chomp::Bool=true)
     close(stdout.in)
     out = stdout.out
     # implicitly close after reading lines, since we opened
-    return EachLine(out, chomp=chomp,
-        ondone=()->(close(out); success(processes) || pipeline_error(processes)))
+    return EachLine(out,
+        ()->(close(out); success(processes) || pipeline_error(processes)), chomp)
 end
 eachline(cmd::AbstractCmd; chomp::Bool=true) = eachline(cmd, DevNull, chomp=chomp)
 

test/iterators.jl

@@ -29,11 +29,11 @@ end
 let b = IOBuffer("foo\n")
     @test collect(EachLine(b)) == ["foo"]
     seek(b, 0)
-    @test collect(EachLine(b, chomp=false)) == ["foo\n"]
+    @test collect(EachLine(b, ()->nothing, false)) == ["foo\n"]
     seek(b, 0)
-    @test collect(EachLine(b, ondone=()->0)) == ["foo"]
+    @test collect(EachLine(b, ()->0)) == ["foo"]
     seek(b, 0)
-    @test collect(EachLine(b, chomp=false, ondone=()->0)) == ["foo\n"]
+    @test collect(EachLine(b, ()->0, false)) == ["foo\n"]
 end
 
 # enumerate (issue #6284)