Feature request: allow TimePeriod constructors of the form 25*Millisecond

[jiahao]

Currently one has to construct a TimePeriod using the constructor syntax Dates.Millisecond(25). In contrast, it is much more natural to use Millisecond as a unary postfix unit (like what SIUnits.jl does), and have 25*Dates.Millisecond produce the same result.

[milktrader]

+1

[quinnj]

We could define lowercase as a unit millisecond = Millisecond(1) or overload *(x,::Type{Millisecond}) = x*Millisecond(1). Honestly I kind of prefer how it is though; personally I find Millisecond(25) to be more natural.

[milktrader]

We could have both, no?

[jiahao]

Consider the use cases involving time arithmetic:

Minute(30)/Second(1) vs (30*Minute)/(1*Second)

or

Hour(6) + Minute(28) + Second(3) vs 6Hour + 28Minute + 3Second

The latter expressions feel much more natural as scientific calculations.

[nalimilan]

+1, but it feels more natural in lowercase.

[jiahao]

I'm sure the Germans would disagree ;)

I thought lowercase constructors were going away in #1470?

[quinnj]

Technically millisecond wouldn't be a constructor, just a "unit".

[quinnj]

I think Millisecond(25) is simple enough; we can re-open if people want to further discuss or voice more support for this now-3.5-year-old issue.