You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't have time to make this a PR right now, so this is just a placeholder so it doesn't get lost: see https://groups.google.com/d/msg/julia-users/2uaRs3JIdfw/hMLdj6wxCwAJ. The most important change was making the string encoding a type parameter of what is effectively EachLine, and then using that in downstream code to prevent type instability.
Looks like this is another issue which will get fixed by merging ASCIIString and UTF8String into a single String type (#14383), which should get rid of type instability in EachLine.
@timholy What other lessons to you draw from that thread regarding thread processing? I must say it's not immediately obvious to me.
I don't have time to make this a PR right now, so this is just a placeholder so it doesn't get lost: see https://groups.google.com/d/msg/julia-users/2uaRs3JIdfw/hMLdj6wxCwAJ. The most important change was making the string encoding a type parameter of what is effectively
EachLine
, and then using that in downstream code to prevent type instability.Without this, on the "Hungarian Wikipedia" test data set (see https://github.com/juditacs/wordcount), some lines come back as
UTF8String
and some asASCIIString
. Might as well keep it consistent.The text was updated successfully, but these errors were encountered: