fix and test datatype field reflection #14777
Merged
+121
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
True, but there is much to be said for this API over ouch. I think we should deprecate |
|
ouch is right. but it's trivial to lift the rest of that computation into the same let block that is computing |
|
Still, |
|
agreed. i'll switch the PR. |
vtjnash
changed the title
vtjnash
force-pushed
the
jn/field-offset
branch
2 times, most recently
from
b37c955 to
64b396b
Compare
|
updated per discussion |
|
|
||
| @deprecate field_offset(x::DataType, idx) fieldoffset(x, idx+1) | ||
| @noinline function fieldoffsets(x::DataType) | ||
| depwarn("fieldoffsets deprecated. use `map(idx->fieldoffset(x, idx), 1:nfields(x))` instead", :fieldoffsets) |
`field_offset` was untested, undocumented, unexported, and incorrect (off-by-one error in implementation) `fieldoffset` just isn't particularly optimal, since it has to allocate a new array each time also make minor cleanup and test-coverage enhancements to related reflection methods
vtjnash
force-pushed
the
jn/field-offset
branch
from
64b396b to
abd3a91
Compare
vtjnash
added a commit
that referenced
this pull request
Jan 25, 2016
fix and test datatype field reflection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces field_offset with corrected, tested, an documented method
fieldoffsetthis function was untested, undocumented, unexported, and incorrect (off-by-one error in implementation)see 30a44c9#commitcomment-15624022