Missing convert(Vector, ::SubArray)

[cstjean]

On 0.4:

convert(Vector, slice(collect(1:10), 2:4))

is not defined, while convert(Array, slice(...)) is. I don't have 0.5 yet - please close if it's fixed there.

[nalimilan]

Doesn't work on 0.5 either.

[Evizero]

This may be a stupid question, but should convert work like that?

This code does work (v0.4):

convert(Vector{Int}, slice(collect(1:10), 2:4))

3-element Array{Int64,1}:
 2
 3
 4

So does

convert(Vector{Float64}, slice(collect(1:10), 2:4))

3-element Array{Float64,1}:
 2.0
 3.0
 4.0

Then again, if it works with convert(Array, ...) it would make sense to also work with Vector

EDIT: copied wrong code at first

[Sacha0]

Then again, if it works with convert(Array, ...) it would make sense to also work with Vector

Having convert(Vector, view(collect(1:10), 1:2)) work would be consistent with the direction in #17066 / related threads. Adding

convert{T}(::Type{Vector}, A::AbstractVector{T}) = convert(Vector{T},  A)

just after this line should do the trick? And if so, might as well add

convert{T}(::Type{Matrix}, A::AbstractMatrix{T}) = convert(Matrix{T}, A)

in the process? Or perhaps a more generic solution exists? Best!

[Evizero]

it can't go in abstractarray.jl because it will make compilation fail. array.jl seems like the best place. I am investigating

[Sacha0]

it can't go in abstractarray.jl because it will make compilation fail. array.jl seems like the best place. I am investigating

Good call, array.jl sounds like the best place. Best!

[nalimilan]

Fixed in master by #17848. Waiting for backport to 0.5.