-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fail to compile mbedtls for julia 0.5.0-rc1 #17920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Seems like CMake is having trouble rewriting the RPATH? For some libraries we do that manually using patchelf. I guess we could do the same for MbedTLS, though it is surprising that no rpath is being set in the first place. Can you look in the full compile commands if that's just not being passed or if the compiler is just not adding it for some reason? |
Where can I find this? |
Maybe here:
|
Yep |
This patch allowed me to compile mbedtls: Index: julia-0.5.0-rc1/deps/mbedtls.mk
===================================================================
--- julia-0.5.0-rc1.orig/deps/mbedtls.mk
+++ julia-0.5.0-rc1/deps/mbedtls.mk
@@ -23,7 +23,7 @@ MBEDTLS_OPTS += -DENABLE_ZLIB_SUPPORT=ON
endif
ifeq ($(OS),Linux)
-MBEDTLS_OPTS += -DCMAKE_INSTALL_RPATH="\$$ORIGIN"
+MBEDTLS_OPTS += -DCMAKE_SKIP_BUILD_RPATH=FALSE -DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE -DCMAKE_INSTALL_RPATH="\$$ORIGIN"
endif
$(SRCDIR)/srccache/$(MBEDTLS_SRC).tgz: | $(SRCDIR)/srccache However, I have no idea if this is the right approach. |
Does the resulting binary have an RPATH set (~/julia/usr/tools/patchelf --print-rpath or objdump -x to check) |
I need to check this in which file? |
If you mean
|
I think Keno meant the mbedcrypto library. What distro and cmake version is this? If you're building a package against system copies of libgit2, you might not need mbedtls at all if the libgit2 you're building against supports https and proxies. |
@tkelman, I'm pretty sure that |
I don't know whether |
Without |
ref #17884 |
The
But I think it is not related to this problem, right? |
I opened a new bug #17941 |
And what was rpath on the mbedcrypto library? We would like to resolve the issue you were having with source builds if it's reproducible with a standard-configuration |
@tkelman it turns out that mbedtls was not built. The source was not even unpacked. I have no idea what happened, but I could not make it build even if the patch I proposed. I think that the build process (openSUSE) added the libgit2 and julia skipped mbedtls. As of now, I cannot build mbedtls together with julia. |
Are you setting anything in |
@tkelman actually I'm trying to make a package for openSUSE. Here is what I'm using for the make command line:
|
For the records, if |
In that case I'll close this as a duplicate of #17884. That kind of information would be best to include with the initial bug report next time. |
@tkelman sorry, I didn't understand. I just discovered that I can build julia without mbedtls after I opened this bug report. |
That list would have been valuable to include when you initially opened the issue is all, so we can have as much information as possible to understand what's going on and correctly diagnose the problem. |
Ah! Ok :) sorry |
Hi guys!
I'm trying to pack julia 0.5.0-rc1, but the mbedtls is failing with this message:
Can anyone help me?
The text was updated successfully, but these errors were encountered: