Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add special display for ≈ test failures #19898

Closed
StefanKarpinski opened this issue Jan 6, 2017 · 3 comments
Closed

add special display for ≈ test failures #19898

StefanKarpinski opened this issue Jan 6, 2017 · 3 comments
Labels
display and printing Aesthetics and correctness of printed representations of objects. Hacktoberfest Good for Hacktoberfest participants help wanted Indicates that a maintainer wants help on an issue or pull request testsystem The unit testing framework and Test stdlib

Comments

@StefanKarpinski
Copy link
Member

As noted by @cstjean in #19880, @test a ≈ b differs from @test_approx_eq a b in that the former doesn't display test failures quite as nicely. We already have specialized code for displaying some kinds of comparisons nicely, so perhaps we should have more logic there to display approximate equality failures as nicely as @test_approx_eq does.
@StefanKarpinski StefanKarpinski added testsystem The unit testing framework and Test stdlib help wanted Indicates that a maintainer wants help on an issue or pull request labels Jan 6, 2017
@StefanKarpinski StefanKarpinski mentioned this issue Jan 6, 2017
Closed
@kshyatt kshyatt added the display and printing Aesthetics and correctness of printed representations of objects. label Jan 8, 2017
@akaysh
Copy link
Contributor

akaysh commented Jan 11, 2017

@StefanKarpinski I would like to work on this. A little more info on what is to be done?

@fredrikekre fredrikekre added the Hacktoberfest Good for Hacktoberfest participants label Sep 28, 2017
@Moelf
Copy link
Contributor

Moelf commented Oct 2, 2020 

julia> using Test

julia> @test 2.1 ≈ 1+1
Test Failed at REPL[2]:1
  Expression: 2.1 ≈ 1 + 1
   Evaluated: 2.1 ≈ 2
ERROR: There was an error during testing

julia> @test 2.1 == 1+1
Test Failed at REPL[3]:1
  Expression: 2.1 == 1 + 1
   Evaluated: 2.1 == 2
ERROR: There was an error during testing

looks find on master now?

@omus
Copy link
Member

omus commented Oct 2, 2020

I believe this was addressed by #30721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
display and printing Aesthetics and correctness of printed representations of objects. Hacktoberfest Good for Hacktoberfest participants help wanted Indicates that a maintainer wants help on an issue or pull request testsystem The unit testing framework and Test stdlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@StefanKarpinski @kshyatt @omus @Moelf @akaysh @fredrikekre