Sockets: Add UDP multicast group support #35521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmaykm
reviewed
Apr 30, 2020
vtjnash
reviewed
Apr 30, 2020
| @@ -22,6 +22,8 @@ export | |||
| recv, | |||
| recvfrom, | |||
| send, | |||
| join_multicast_group, | |||
| leave_multicast_group, | |||
There was a problem hiding this comment.
Nodejs calls these "addMembership/addSourceSpecificMembership" and "dropMembership/dropSourceSpecificMembership" (https://nodejs.org/dist/latest-v14.x/docs/api/dgram.html)
There was a problem hiding this comment.
Yeah, I see a lot of different names around. I figured that these names were as self-explanatory as possible.
vtjnash
approved these changes
Apr 30, 2020
staticfloat
force-pushed
the
sf/udp_multicast
branch
from
362e9f2 to
7bee5d6
Compare
Adds two functions `join_multicast_group()` and `leave_multicast_group` for usage with UDP multicast groups.
staticfloat
force-pushed
the
sf/udp_multicast
branch
from
7bee5d6 to
e1d8da1
Compare
|
Great job! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two functions
join_multicast_group()andleave_multicast_groupfor usage with UDP multicast groups. Closes #21300