add a TOML standard library to Julia #37034
Merged
+8,689
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/toml_stdlib
branch
from
15e7c17 to
4160db2
Compare
|
If it's going to have tight integration with code in It looks like the windows tests are failing because it's trying to import JSON and can't? |
|
Only as tight of an integration that code loading can actually use it. It's pretty nice to have all issues in one place. Hm. |
|
I think stdlib tests don't get their |
|
Yeah, they don't run with Pkg.test. |
KristofferC
force-pushed
the
kc/toml_stdlib
branch
from
ed68805 to
a341744
Compare
KristofferC
changed the title
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a TOML standard library for parsing and writing TOML files.
The source files currently reside in https://github.com/KristofferC/TOML.jl. The reason for this is that there is already a TOML repository in the JuliaLang organization which should probably be moved.The current docs can be found at https://kristofferc.github.io/TOML.jl/dev/.
The parser part is the same as in #36018 (with the review comments applied).
After this is merged, we should move the parser part into Base and rebase #36018 on top of it.
Since the parser part is going to be in Base, it isn't clear to me whether all files for the stdlib should be in this repo or if it still makes sense to have a separate repo for e.g. issues.cc @StefanKarpinski, @staticfloat