Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--project stopped working with --output-o in 1.6-DEV? #37441

Closed
tkf opened this issue Sep 7, 2020 · 1 comment
Closed

--project stopped working with --output-o in 1.6-DEV? #37441

tkf opened this issue Sep 7, 2020 · 1 comment
Assignees
Labels
regression Regression in behavior compared to a previous version
Milestone

Comments

@tkf
Copy link
Member

tkf commented Sep 7, 2020

When I run julia --startup-file=no --sysimage=PATH/TO/sys.so --project=. --output-o=dummy -e 'Base.reinit_stdio(); @eval Sys BINDIR = ccall(:jl_get_julia_bindir, Any, ())::String; Base.init_load_path(); @show Base.load_path()' (as would be executed via PackageCompiler.create_sysimage), Julia 1.5.0 prints something like

Base.load_path() = ["$PWD/Project.toml", "/buildworker/worker/package_linux64/build/usr/bin/../share/julia/stdlib/v1.5"]

while Julia 1.6.0-DEV.851 prints

Base.load_path() = [""]

I think this is causing recent failures in system image build tests in PyCall (e.g., https://travis-ci.org/github/JuliaPy/PyCall.jl/jobs/722001094#L738).

Perhaps an easier way to observe this is to edit PackageCompiler.jl

diff --git a/src/PackageCompiler.jl b/src/PackageCompiler.jl
index 3d1a177..32daec1 100644
--- a/src/PackageCompiler.jl
+++ b/src/PackageCompiler.jl
@@ -238,6 +238,7 @@ function create_sysimg_object_file(object_file::String, packages::Vector{String}
         @eval Sys BINDIR = ccall(:jl_get_julia_bindir, Any, ())::String
         Base.init_load_path()
         Base.init_depot_path()
+        @show Base.load_path()
         """

     # Ensure packages to be put into sysimage are precompiled by loading them in a

and then run create_sysimg with non-default project path.

cc @KristofferC

@KristofferC
Copy link
Member

#36434 requires us to call Base.init_active_project().

Should be fixed by JuliaLang/PackageCompiler.jl#460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

2 participants