Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile: Add a native way to display allocation profiler output #46742

Open
IanButterworth opened this issue Sep 13, 2022 · 2 comments
Open

Profile: Add a native way to display allocation profiler output #46742

IanButterworth opened this issue Sep 13, 2022 · 2 comments
Labels
docs This change adds or pertains to documentation profiler

Comments

@IanButterworth
Copy link
Member

AFAIK the allocation profiler added in 1.8 doesn't have a native way to view the output, akin to Profile.print().

It seems reasonable to expect Profile to be able to make a basic report, and not fully depend on external packages (PProf / the vscode extension)
@IanButterworth IanButterworth added docs This change adds or pertains to documentation profiler labels Sep 13, 2022
@nickrobinson251
Copy link
Contributor

(For those who land on this issue but not #45268...) @vtjnash shared some code for a Profile.Allocs.print (#45268 (comment)): https://gist.github.com/vtjnash/c6aa4db9dafccb0fd28a65f87d6b1adb

I've been trying it out and found it pretty helpful!

What would be needed to get that functionality merged in?

@vtjnash
Copy link
Member

vtjnash commented Sep 28, 2022

Probably someone writing a couple basic tests and making a PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation profiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vtjnash @IanButterworth @nickrobinson251