Skip to content

Store tolerances in ValidationManifold #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kellertuer opened this issue Feb 25, 2025 · 0 comments
Open

Store tolerances in ValidationManifold #224

kellertuer opened this issue Feb 25, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kellertuer
Copy link
Member

For the validation it might be nice to store a tolerance, atol maybe or rtol or maybe even keywords in general

  • globally (for all tests)
  • locally per function (similar to the activation)

The design/struct change for this should be not too large – maybe a bit tricky to get that nicely represented in keywords – but most functions would need to extract this from the ValidationManifold before calling their is_X functions – that might be a bit of (though merely repetitive) work.

@kellertuer kellertuer added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 25, 2025
@kellertuer kellertuer changed the title Sore tolerances in ValidationManifold Store tolerances in ValidationManifold Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant