Skip to content

Commit 6b10054

Browse files
authored
Merge pull request #538 from m-fila/docs_fix
Fix typos in documentation, tests and benchmarks
2 parents 89fd00c + d0583be commit 6b10054

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

Diff for: benchmarks/suites/dtable.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ function dtable_suite(ctx; method, accels)
7575
fetch_wait(dt)
7676
end setup=begin
7777
genchunk = $genchunk
78-
@info "$(time_ns()) Writing mutiple CSVs"
78+
@info "$(time_ns()) Writing multiple CSVs"
7979
path = mktempdir()
8080
nchunks = $nchunks
8181
wait.([Threads.@spawn CSV.write(joinpath(path, "datapart_$i.csv"), genchunk(MersenneTwister(1111+i), nchunks)) for i in 1:nchunks])

Diff for: benchmarks/visualize.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ push!(legend_names, "cpu+dagger")
119119
legend = fig[1, 2] = Legend(fig, line_plots, legend_names)
120120
save("weak_scaling.png", fig)
121121

122-
# 3. Comparision against Base
122+
# 3. Comparison against Base
123123

124124
fig = Figure(resolution = (1200, 800))
125125
perf = fig[1, 1] = Axis(fig, title = "Dagger vs Base")

Diff for: docs/src/datadeps.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ Dagger.spawn_datadeps() do
128128
end
129129
```
130130

131-
The other way allows you to seperate what argument is passed to the function,
131+
The other way allows you to separate what argument is passed to the function,
132132
from how that argument is accessed within the function. This is done with the
133133
`Deps` wrapper, which is used like so:
134134

Diff for: docs/src/dynamic.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ various uses:
2727
When working with thunks acquired from `get_dag_ids` or `add_thunk!`,
2828
you will have `ThunkID` objects which refer to a thunk by ID. Scheduler
2929
control functions which work with thunks accept or return `ThunkID`s. For
30-
example, one can create a new thunkt and get its result with `Base.fetch`:
30+
example, one can create a new thunk and get its result with `Base.fetch`:
3131

3232
```julia
3333
function mythunk(x)

Diff for: docs/src/task-spawning.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ key-value pairs, which can be any of:
3737
- `meta::Bool` -- Pass the input [`Chunk`](@ref) objects themselves to `f` and
3838
not the value contained in them.
3939

40-
There are also some extra optionss that can be passed, although they're considered advanced options to be used only by developers or library authors:
40+
There are also some extra options that can be passed, although they're considered advanced options to be used only by developers or library authors:
4141
- `get_result::Bool` -- return the actual result to the scheduler instead of [`Chunk`](@ref) objects. Used when `f` explicitly constructs a [`Chunk`](@ref) or when return value is small (e.g. in case of reduce)
4242
- `persist::Bool` -- the result of this Thunk should not be released after it becomes unused in the DAG
4343
- `cache::Bool` -- cache the result of this Thunk such that if the thunk is evaluated again, one can just reuse the cached value. If it’s been removed from cache, recompute the value.

Diff for: docs/src/use-cases/parallel-nested-loops.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ In this code we have job interdependence. Firstly, we are calculating the
7474
standard deviation `σ` and than we are using that value in the function `f`.
7575
Since `Dagger.@spawn` yields an `DTask` rather than actual values, we need
7676
to use the `fetch` function to obtain those values. In this example, the value
77-
fetching is perfomed once all computations are completed (note that `@sync`
77+
fetching is performed once all computations are completed (note that `@sync`
7878
preceding the loop forces the loop to wait for all jobs to complete). Also,
7979
note that contrary to the previous example, we do not need to implement locking
8080
as we are just pushing the `DTask` results of `Dagger.@spawn` serially

Diff for: test/processors.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ end
1919
@test op isa OSProc
2020
@test op.pid == 1
2121
end
22-
@testset "Function/argument compatability" begin
22+
@testset "Function/argument compatibility" begin
2323
unknown_func = () -> nothing
2424
tp = ThreadProc(1, 1)
2525
op = get_parent(tp)

0 commit comments

Comments
 (0)