Skip to content

Commit b4f41c8

Browse files
authored
Merge pull request #484 from JamesWrigley/undefined-variable
Reference Dagger.EAGER_THUNK_STREAMS explicitly
2 parents 6b9a1af + 73c62dc commit b4f41c8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: src/sch/eager.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ function eager_cleanup(state, uid)
117117
delete!(state.thunk_dict, tid)
118118
end
119119
remotecall_wait(1, uid) do uid
120-
lock(EAGER_THUNK_STREAMS) do global_streams
120+
lock(Dagger.EAGER_THUNK_STREAMS) do global_streams
121121
if haskey(global_streams, uid)
122122
delete!(global_streams, uid)
123123
end

Diff for: src/submission.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ end
186186
function EagerThunkMetadata(spec::EagerTaskSpec)
187187
f = chunktype(spec.f).instance
188188
arg_types = ntuple(i->chunktype(spec.args[i][2]), length(spec.args))
189-
return_type = Base._return_type(f, Base.to_tuple_type(arg_types))
189+
return_type = Base.promote_op(f, arg_types...)
190190
return EagerThunkMetadata(return_type)
191191
end
192192
chunktype(t::EagerThunk) = t.metadata.return_type

0 commit comments

Comments
 (0)