Skip to content

Feature Request: Support init argument for reduce functions. #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
schlichtanders opened this issue Mar 5, 2024 · 1 comment · Fixed by #485
Closed

Feature Request: Support init argument for reduce functions. #475

schlichtanders opened this issue Mar 5, 2024 · 1 comment · Fixed by #485

Comments

@schlichtanders
Copy link

schlichtanders commented Mar 5, 2024

While DTables.jl supports the init for mapreduce officially in its documentation, DArray has no documentation about its reduce functionality, and those existing in the code do not support the init keyword.

It would be great if also DArray.jl supports init for the reduce functions to efficiently run something like OnlineStats over them.

I've been looking at this file for the current implementations.

@schlichtanders schlichtanders changed the title Featur Request: Support init argument for reduce functions. Feature Request: Support init argument for reduce functions. Mar 7, 2024
@jpsamaroo
Copy link
Member

Thanks for the report! The entire DArray map/reduce functionality is a bit of a mess - I'll clean it up and then plumb through init. I can add some tests for OnlineStats specifically - it's certainly something I expect users to be able to use reliably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants