Skip to content

Updating to Documenter.jl v1 #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JamesWrigley opened this issue Mar 11, 2024 · 4 comments
Closed

Updating to Documenter.jl v1 #482

JamesWrigley opened this issue Mar 11, 2024 · 4 comments

Comments

@JamesWrigley
Copy link
Collaborator

I attempted to update the docs to build with Documenter.jl v1, but it seems that there are dependency conflicts. I narrowed it down to:

This PR would fix it: kimikage/ProfileSVG.jl#70
But I'm not sure if that'll get merged anytime soon. Anyway it's not urgent, I just wanted to document the chain of pain 😁

@jpsamaroo
Copy link
Member

Thanks for looking into this! I'd be ok with removing ProfileSVG support from DaggerWebDash for now - it's not really used, since profiling support in Dagger isn't great, because Profile doesn't support continuous profiling (yet another chain of pain 😆 ).

@asinghvi17
Copy link

If it's a web viewer, you could try switching to ProfileCanvas.jl instead? Not sure if it needs a live server, though.

Alternatively, you can always just add that branch in CI explicitly!

@jpsamaroo
Copy link
Member

The live rendering support is enabled by running ProfileSVG multiple times, so ProfileCanvas.jl could work! Thanks for letting me know about it 😄

@JamesWrigley
Copy link
Collaborator Author

Fixed in #487.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants