Tests are failing on Julia >= 1.6

[andreasnoack]

It seems that something has regressed while CI hasn't been running. See e.g. https://github.com/JuliaParallel/DistributedArrays.jl/runs/3343634807?check_suite_focus=true. Here is one of the errors.

test convert from subdarray: Error During Test at /home/runner/work/DistributedArrays.jl/DistributedArrays.jl/test/darray.jl:759
  Test threw exception
  Expression: s == DArray(s)
  TaskFailedException
  
      nested task error: On worker 2:
      MethodError: no method matching reindex(::SubArray{Float64, 2, DArray{Float64, 2, Matrix{Float64}}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false}, ::Tuple{UnitRange{Int64}, UnitRange{Int64}}, ::Tuple{UnitRange{Int64}, UnitRange{Int64}})
      Closest candidates are:
        reindex(::Tuple{Real, Vararg{Any, N} where N}, ::Tuple) at subarray.jl:245
        reindex(::Tuple{Base.Slice, Vararg{Any, N} where N}, ::Tuple{Any, Vararg{Any, N} where N}) at subarray.jl:249
        reindex(::Tuple{AbstractVector{T} where T, Vararg{Any, N} where N}, ::Tuple{Any, Vararg{Any, N} where N}) at subarray.jl:253
        ...
      Stacktrace:
       [1] #84
         @ ~/work/DistributedArrays.jl/DistributedArrays.jl/src/darray.jl:603
       [2] #construct_localparts#5
         @ ~/work/DistributedArrays.jl/DistributedArrays.jl/src/darray.jl:118
       [3] construct_localparts
         @ ~/work/DistributedArrays.jl/DistributedArrays.jl/src/darray.jl:118
       [4] #106
         @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:278
       [5] run_work_thunk
         @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:63
       [6] macro expansion
         @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:278 [inlined]
       [7] #105
         @ ./task.jl:411

@mbauman Do you have any idea what could have changed here? It looks like the reindex methods haven't changed since 1.2.

[andreasnoack]

There are deprecation warnings in the old Travis logs related to reindex, see https://travis-ci.org/github/JuliaParallel/DistributedArrays.jl/jobs/770116060, so it must be JuliaLang/julia#30789 and I can see that @mbauman already has a PR for that #220 which never got merged.

[andreasnoack]

Fixed by #220