Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track performance regressions.Implement set of benchmarks. #89

Closed
amitmurthy opened this issue Aug 2, 2016 · 2 comments
Closed

Track performance regressions.Implement set of benchmarks. #89

amitmurthy opened this issue Aug 2, 2016 · 2 comments

Comments

@amitmurthy
Copy link
Contributor

Looking at a few other packages I noticed a 10-15% slowdown between 0.4 and master. However, DistributedArrays is showing a slowdown for the entire test suite run of around 20-30%. The underlying causes for this may very well be in Base. This issue has been created to help track down specific instances of slowdown so that they may be addressed better in Base.

@vchuravy
Copy link
Member

vchuravy commented Aug 2, 2016

Are these actual performance regression or is this the penalty coming in from longer compile times + closures? We should probably come up with a set of benchmarks that we can test with BenchmarkTools

@amitmurthy
Copy link
Contributor Author

Anecdotal at this point. Considering longer compile times are the same across packages and that closures have been optimized in 0.5, comparing, for example, PR histories of DataFrames and ProtoBuf, they have seen a slowdown of approx. 10% while it is considerably more here.

@amitmurthy amitmurthy changed the title Performance regression on master (test suite run timings) Track performance regressions.Implement set of benchmarks. Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants