Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization fails for Julia with DEV in version #106

Closed
jlapeyre opened this issue Feb 10, 2022 · 1 comment
Closed

Initialization fails for Julia with DEV in version #106

jlapeyre opened this issue Feb 10, 2022 · 1 comment

Comments

@jlapeyre
Copy link

jlapeyre commented Feb 10, 2022

> julia --version
julia version 1.8.0-DEV

> python -m juliacall
Traceback (most recent call last):
  ...
  File "/home/lapeyre/code/github/cjdoris/PythonCall/juliacall/semver.py", line 59, in __init__
    self.parts = tuple(map(int, src))
ValueError: invalid literal for int() with base 10: '0-DEV'

PythonCall.jl master branch 05237b2

This appears to have been introduced in EDIT: cb207df the most recent commit.

The following prevents the error:

        elif isinstance(src, str):
            src = src.strip().split('.')
            if len(src) == 3:
                prerel = src[2].split('-')
                if len(prerel) == 2:
                    src[2] = prerel[0]
                    self.prerel = prerel[1]

But, this just ignores the prerelease DEV. And the version is accepted. Also, the string being processed "1.8.0-DEV" does not include the prerelease number. That is:

julia> VERSION
v"1.8.0-DEV.1455"
@cjdoris
Copy link
Collaborator

cjdoris commented Feb 11, 2022

Thanks! I'm actually factoring out the dependency management stuff right now and this will get fixed as part of that

@cjdoris cjdoris closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants