Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first import of juliacall clobbers Project.toml #166

Closed
jlapeyre opened this issue Apr 25, 2022 · 3 comments
Closed

first import of juliacall clobbers Project.toml #166

jlapeyre opened this issue Apr 25, 2022 · 3 comments

Comments

@jlapeyre
Copy link

I create a virtual environment in a directory that already contains a Project.toml file (it is the toplevel of a Julia package).
Then I do import juliacall. (Maybe also import juliacall.Main). I may not have had PythonCall installed yet. In any case, it was automatically downloaded. But, a new Project.toml file was written that contained only the PythonCall dependency. This clobbered the existing Project.toml.

Suggested improvement: Add PythonCall to the existing project. Perhaps with a warning. Or throw an error explaining the conflict.

juliacall 0.8.0

@cjdoris
Copy link
Collaborator

cjdoris commented Apr 25, 2022

Project.toml is supposed to be put somewhere private. Do you have JULIA_PROJECT set?

@jlapeyre
Copy link
Author

Yes, I forgot about that. I am using direnv, which sets JULIA_PROJECT.

@cjdoris
Copy link
Collaborator

cjdoris commented May 8, 2022

I've just pushed a change so that JULIA_PROJECT is now ignored by JuliaPkg. You can use PYTHON_JULIAPKG_PROJECT if you like, but note that the clobbering behaviour you observed is international: JuliaPkg "owns" the project it uses so it can freely add/remove packages without worrying about what the user may have put there.

@cjdoris cjdoris closed this as completed May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants