Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module eval should be eval(m, expr) instead of eval(expr) in seval #178

Closed
Roger-luo opened this issue May 25, 2022 · 2 comments
Closed

Comments

@Roger-luo
Copy link

If you create new Julia module

import juliacall as jl

m = jl.newmodule("TestModule")
m.seval("1 + 1")

will not work because m doesn't have eval(::Expr) defined, but only have eval(::Module, ::Expr) this is because the module created using Module doesn't have eval(::Expr) defined. I'm not sure if we should just generate this method manually, but I think if we use Base.eval(::Module, ::Expr) it will always work at least.

@cjdoris
Copy link
Collaborator

cjdoris commented May 26, 2022

Thanks, this is already fixed on main (#170).

@cjdoris cjdoris closed this as completed May 26, 2022
@Roger-luo
Copy link
Author

Roger-luo commented May 26, 2022

Thanks! I didn't notice that PR, would it be possible to tag release soon? So my python wrapper package can pass tests on CI. @cjdoris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants