Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lazy loading of micromamba/pixi_jll #171

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Fix lazy loading of micromamba/pixi_jll #171

merged 4 commits into from
Mar 3, 2025

Conversation

cjdoris
Copy link
Collaborator

@cjdoris cjdoris commented Mar 3, 2025

@cjdoris cjdoris merged commit 03f8a36 into main Mar 3, 2025
10 checks passed
@cjdoris cjdoris deleted the precompile-bug branch March 3, 2025 11:57
@@ -183,7 +183,7 @@ end
packages =
Dict("foo" => Dict("test.toml" => CondaPkg.PkgSpec("foo", channel = "bad-channel")))
channels = [CondaPkg.ChannelSpec("conda-forge")]
@test nothing ===
@test true ===
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true === is extra now I think

@KristofferC
Copy link

I just want to say that the idea of loading packages based on some dynamic information in __init__ is not a good idea. It kind of breaks the precompilation system. I'd suggest just taking the hit of either having to download the artifacts for both micromamba and pixi or make the artifacts lazy so they are only used when first accessed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SciMLBasePythonCallExt always precompiling, CondaPkg 0.2.25 regression Precompile cache misses
3 participants