Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Issues For Nightly KIC Test Failures #2614

Open
2 tasks
shaneutt opened this issue Jun 28, 2022 · 5 comments
Open
2 tasks

Automatic Issues For Nightly KIC Test Failures #2614

shaneutt opened this issue Jun 28, 2022 · 5 comments

Comments

@shaneutt
Copy link
Contributor

shaneutt commented Jun 28, 2022

Problem Statement

In the past there have been some nightly test failures that have taken longer for us to resolve than we would have liked. The purpose of this task is to add automatic issue creation whenever this occurs to help increase the noise made from a failure.

Disambiguation: this is about KIC tests that we run nightly; not tests that we run against Kong Gateway nightly builds.

Acceptance Criteria

  • issues are now created at severity/high for any nightly test run failure
  • issues are deduplicated by failed test name (or some other reasonable identifier); if an existing issue is closed, a failure reopens it with a comment linking to the failure.
@pmalek
Copy link
Member

pmalek commented Jun 29, 2022

This looks relatively easy to do with e.g. https://github.com/marketplace/actions/create-github-issue

steps:
  - uses: actions/checkout@v3
  - name: Something that might fail
    run: exit 1
  - name: Create Issue on Failed workflow
    if: ${{ failure() }}
    uses: dacbd/create-issue-action@main
    with:
      token: ${{ github.token }}
      title: Action workflow failed.
      body: |
        ### Context
        [Failed Run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
        [Codebase](https://github.com/${{ github.repository }}/tree/${{ github.sha }})
        Workflow name - `${{ github.workflow }}`
        Job -           `${{ github.job }}`
        status -        `${{ job.status }}`
      assignees: SomeUsername,AnotherUsername

@shaneutt
Copy link
Contributor Author

Sounds good.

@mflendrich
Copy link
Contributor

Blocked until we get rid of frequent causes for test flakiness (and get test flakiness under a "reasonable" threshold).

@mflendrich mflendrich changed the title Automatic Issues For Nightly Test Failures Automatic Issues For Nightly KIC Test Failures Aug 2, 2022
@mflendrich
Copy link
Contributor

Concern by @rainest: this might end up with numerous reports for the test failing time after time.

Proposed solution: dedup by test case name. The automation would reopen the issue when an issue for this test case name fails (and comment with the run ID).

@mflendrich mflendrich assigned mflendrich and unassigned mflendrich Aug 2, 2022
@mflendrich
Copy link
Contributor

Another alternative proposed by @rainest and @pmalek: use external tooling to visualize trends in failures for specific test cases.

@lahabana lahabana removed this from the Fixit 2023 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants