Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools automatic dependabot updates require validation of manifests #2643

Open
pmalek opened this issue Jul 1, 2022 · 0 comments
Open

Tools automatic dependabot updates require validation of manifests #2643

pmalek opened this issue Jul 1, 2022 · 0 comments

Comments

@pmalek
Copy link
Member

pmalek commented Jul 1, 2022

After #2600 and #2636 have been merged dependabot will create dependency updates for tools defined in third_part/go.mod.

The problem is that changes to versions of those tools might entail changes in manifests e.g. all-in-one manifests.

In order to prevent diverging tools' versions and manifests (created by those tools) let's implement a mechanism that will automatically trigger manifests update in the same PR that the tool version bump is being done.

There is a mechanism in place already that will prevent the PRs that update either the tools or the manifests that would result in a diff when manifests are recreated so this types of PRs shouldn't get merged into main.

Proposed solution

The solution that will be implemented to solve this issue could utilize these Github Actions:

Please note that in order to trigger a subsequent workflow, a Personal Access Token has to be used (instead of GITHUB_TOKEN available in workflows) because only those can trigger a workflow run from another workflow. Docs documenting this use case: https://github.com/marketplace/actions/git-auto-commit#commits-made-by-this-action-do-not-trigger-new-workflow-runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants