Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IngressClassV1 related functions in store.Store accept a class name argument #2705

Open
3 tasks
pmalek opened this issue Jul 15, 2022 · 3 comments
Open
3 tasks
Labels

Comments

@pmalek
Copy link
Member

pmalek commented Jul 15, 2022

Problem statement

store.Store's IngressClassV1 related functions do not accept ingress class as parameter. As of now this is not problematic but relies on filling store's ingressClass field.

We can make this more parametrized by using ingress class as parameter in IngressClassV1 related functions.

Acceptance criteria

Additional information

Original comment this idea came from: Originally posted by @rainest in #2535 (comment)

@mflendrich
Copy link
Contributor

@pmalek please scope this issue appropriately using the issue template. Looks like this is a part of a larger whole (that is, supporting multiple ingress classes within a single KIC) - please ensure that we have an issue trackign that larger effort as well.

@pmalek
Copy link
Member Author

pmalek commented Dec 5, 2022

I've added acceptance criteria and reworded the issue statement.

@mflendrich
Copy link
Contributor

No current demand for this feature, putting this in the freezer until further reevaluation.

@mflendrich mflendrich removed this from the KIC input for 2.9/2.10 milestone Jan 3, 2023
@programmer04 programmer04 added this to the Fixit 2023 milestone Sep 25, 2023
@pmalek pmalek removed their assignment Apr 4, 2024
@lahabana lahabana removed this from the Fixit 2023 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants