You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
store.Store's IngressClassV1 related functions do not accept ingress class as parameter. As of now this is not problematic but relies on filling store's ingressClass field.
We can make this more parametrized by using ingress class as parameter in IngressClassV1 related functions.
Subsequently, a decision has to be made whether to pursue multiple ingress class support and appropriate comment with justification has to be posted in this issue.
If we decide to follow up this route then as part of this issue we have to create new issue to make appropriate changes in code (so that we do not piggy back on this one).
@pmalek please scope this issue appropriately using the issue template. Looks like this is a part of a larger whole (that is, supporting multiple ingress classes within a single KIC) - please ensure that we have an issue trackign that larger effort as well.
Problem statement
store.Store
'sIngressClassV1
related functions do not accept ingress class as parameter. As of now this is not problematic but relies on filling store'singressClass
field.We can make this more parametrized by using ingress class as parameter in
IngressClassV1
related functions.Acceptance criteria
IngressClassV1
related functions in https://github.com/Kong/kubernetes-ingress-controller/blob/6988320be0b461f09a5213634a8be8bc39b549a6/internal/store/store.go accept an ingress class parameterAdditional information
Original comment this idea came from: Originally posted by @rainest in #2535 (comment)
The text was updated successfully, but these errors were encountered: