Update eslint and apply leankit rules

Author: JohnDMathis

.eslintrc

@@ -0,0 +1,10 @@
+module.exports = {
+	extends: [ "leankit" ],
+	globals: {
+		lux:true,
+		postal:true
+ 	},
+	rules:{
+		"valid-jsdoc": "off"
+	}
+};

.eslintrc.js

@@ -17,3 +17,4 @@ bower/
 public/js/lib/
 js-dist/
 coverage/
+.vscode/

.gitignore

@@ -25,9 +25,9 @@ module.exports = function( config ) {
 
 		// list of files / patterns to load in the browser
 		files: [
-		"spec/helpers/phantomjs-shims.js",
-		"spec/helpers/karma-setup.js",
-		"spec/**/*.spec.*"
+			"spec/helpers/phantomjs-shims.js",
+			"spec/helpers/karma-setup.js",
+			"spec/**/*.spec.*"
 		],
 
 		// list of files to exclude
@@ -62,7 +62,7 @@ module.exports = function( config ) {
 
 		// start these browsers
 		// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
-		browsers: [ "Chrome" /*, "Safari", "Firefox" */ ],
+		browsers: [ "Chrome" /* , "Safari", "Firefox" */ ],
 
 		coverageReporter: {
 			reporters: [

karma.conf.js

@@ -41,9 +41,12 @@
     "LeanKit"
   ],
   "scripts": {
+    "prebuild":"npm run lint",
     "build": "webpack --config webpack.config.js",
+    "pretest": "npm run lint",
     "test": "karma start --no-auto-watch --single-run",
-    "coverage": "npm run test"
+    "coverage": "npm run test",
+    "lint": "$(npm bin)/eslint --ext=js,jsx ./spec/ ./src/ --fix"
   },
   "peerDependencies": {
     "babel": "6.x",
@@ -57,6 +60,7 @@
   "devDependencies": {
     "babel": "6.x",
     "babel-core": "^6.14.0",
+    "babel-eslint": "^7.0.0",
     "babel-loader": "^6.2.5",
     "babel-plugin-add-module-exports": "^0.2.1",
     "babel-polyfill": "^6.13.0",
@@ -66,6 +70,10 @@
     "chai": "^3.5.0",
     "clean-webpack-plugin": "^0.1.10",
     "dirty-chai": "^1.2.2",
+    "eslint": "^3.5.0",
+    "eslint-config-leankit": "^2.0.0",
+    "eslint-plugin-babel": "^3.3.0",
+    "eslint-plugin-react": "~3.11.3",
     "gulp": "^3.8.8",
     "gulp-changed": "^1.2.1",
     "gulp-eslint": "^0.15.0",

package.json

@@ -0,0 +1,9 @@
+module.exports = {
+	extends: ["leankit/test","leankit/react"],
+	globals:{
+		React:true,
+		ReactDOM:true,
+		utils:true,
+		_:true
+	}
+};

spec/.eslintrc

@@ -42,7 +42,7 @@ describe( "luxJS - Actions", function() {
 			var handlerOne = sinon.spy();
 			var handlerTwo = sinon.spy();
 			var customAction = {
-				[ actionName]: handlerOne
+				[ actionName ]: handlerOne
 			};
 
 			lux.customActionCreator( customAction );

spec/.eslintrc.js

@@ -1,5 +1,7 @@
 // From https://github.com/newtriks/react-automation-example/blob/master/test/helpers/phantomjs-shims.js
 
+/* eslint-disable consistent-this */
+
 ( function() {
 	var Ap = Array.prototype;
 	var slice = Ap.slice;
@@ -32,4 +34,6 @@
 			return bound;
 		};
 	}
-} )();
+}() );
+
+/* eslint-enable consistent-this */

spec/actions.spec.js

@@ -1,3 +1,4 @@
+
 var luxWrapper = lux.luxWrapper;
 function storeFactory( options ) {
 	options = Object.assign( {
@@ -15,7 +16,7 @@ function getMockReactComponent( options ) {
 			return { foo: "bar" };
 		},
 		render: function() {
-			return React.createElement( "div", { className: "childy" }, "This is a test DIV" );
+			return React.createElement( "div", { displayName: "MOM", className: "childy" }, "This is a test DIV" );
 		}
 	}, options ) );
 }
@@ -123,11 +124,11 @@ describe( "luxWrapper", function() {
 			} );
 			it( "should pass expected props to the targetComponent", function() {
 				willReceivePropsStub.should.be.calledWith( {
-						foo: "bar",
-						wrapperProp: "thingy",
-						store2: "statey state state",
-						store1: "state"
-					} );
+					foo: "bar",
+					wrapperProp: "thingy",
+					store2: "statey state state",
+					store1: "state"
+				} );
 			} );
 		} );
 	} );
@@ -142,6 +143,10 @@ describe( "luxWrapper", function() {
 				}
 			} );
 			targetComponent = React.createClass( {
+				propTypes: {
+					onThingThang: React.PropTypes.string,
+					onAnotherThang: React.PropTypes.string
+				},
 				displayName: "ActionMockt",
 				handleClick: function( e ) {
 					this.props.onThingThang( e, "another", "value" );

spec/helpers/phantomjs-shims.js

@@ -1,4 +1,5 @@
 describe( "luxJS - Store", function() {
+	// eslint-disable-next-line max-params
 	function storeFactory( options, m1, m2, m3, m4, m5, m6, m7 ) {
 		options = Object.assign( {
 			namespace: "storeOne",
@@ -35,6 +36,7 @@ describe( "luxJS - Store", function() {
 					} );
 				} ).should.throw( /must have a namespace/ );
 			} );
+
 			it( "Should throw an error if there are no action handlers", function() {
 				var tmpStore;
 				( function() {
@@ -248,15 +250,15 @@ describe( "luxJS - Store", function() {
 						}
 					}
 				}, {
-						handlers: {
-							backInTime: {
-								waitFor: [ "mefirst" ],
-								handler: function() {
-									invocations.push( "mesecond-mixin2" );
-								}
+					handlers: {
+						backInTime: {
+							waitFor: [ "mefirst" ],
+							handler: function() {
+								invocations.push( "mesecond-mixin2" );
 							}
 						}
-					} );
+					}
+				} );
 
 				var store3 = storeFactory(
 					{
@@ -437,8 +439,10 @@ describe( "luxJS - Store", function() {
 			lux.dispatch( "myTest" );
 			storeOne.should.be.calledOnce();
 
+			/* eslint-disable no-console */
 			console.warn.should.be.calledOnce.and.calledWithMatch( /doesNotExist/ );
 			console.warn.restore();
+			/* eslint-enable no-console */
 
 			store.dispose();
 		} );

spec/luxWrapper.spec.js

@@ -0,0 +1,22 @@
+module.exports = {
+	extends: [ "leankit/es6", "leankit/react" ],
+	parser: "babel-eslint",
+	plugins: [ "babel" ],
+	rules: {
+		"no-unused-expressions": 2,
+		"prefer-arrow-callback": 0,
+		"init-declarations": 0,
+		"react/jsx-key": [ 2 ],
+
+		// plugin for babel eslint to fix some problems with the core rules
+		"generator-star-spacing": 0,
+		"babel/generator-star-spacing": [ "error" ],
+		"object-curly-spacing": 0,
+		"babel/object-curly-spacing": [ "error", "always" ],
+		"object-shorthand": 0,
+		"babel/object-shorthand": [ "error", "always" ],
+		"arrow-parens": 0,
+		"babel/arrow-parens": [ "error", "as-needed" ],
+		"babel/no-await-in-loop": "error" // nothing to disable
+	}
+};

spec/store.spec.js

@@ -8,7 +8,7 @@ export function generateActionCreator( actionList ) {
 	actionList.forEach( function( action ) {
 		if ( !actions[ action ] ) {
 			actions[ action ] = function() {
-				var args = Array.from( arguments );
+				const args = Array.from( arguments );
 				actionChannel.publish( {
 					topic: `execute.${action}`,
 					data: {
@@ -27,17 +27,16 @@ export function generateActionCreator( actionList ) {
 export function getActionGroup( group ) {
 	if ( actionGroups[ group ] ) {
 		return _.pick( actions, actionGroups[ group ] );
-	} else {
-		throw new Error( `There is no action group named '${group}'` );
 	}
+	throw new Error( `There is no action group named '${group}'` );
 }
 
 // This method is deprecated, but will remain as
 // long as the print utils need it.
 /* istanbul ignore next */
 export function getGroupsWithAction( actionName ) {
 	const groups = [];
-	for ( var [ group, list ] of entries( actionGroups ) ) {
+	for ( const [ group, list ] of entries( actionGroups ) ) {
 		if ( list.indexOf( actionName ) >= 0 ) {
 			groups.push( group );
 		}