Skip to content

Commit 906c569

Browse files
BordawilliamFalcon
authored andcommitted
Apply suggestions from code review
1 parent 944465e commit 906c569

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

docs/source/introduction_guide.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -285,8 +285,8 @@ However, if you have multiple optimizers use the matching parameters
285285
286286
class LitMNIST(pl.LightningModule):
287287
288-
def configure_optimizers(self):
289-
return Adam(self.generator(), lr=1e-3), Adam(self.discriminator(), lr=1e-3)
288+
def configure_optimizers(self):
289+
return Adam(self.generator(), lr=1e-3), Adam(self.discriminator(), lr=1e-3)
290290
291291
Training step
292292
^^^^^^^^^^^^^

pytorch_lightning/core/lightning.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ def training_step(self, batch, batch_idx, hiddens):
224224
The presented loss value in progress bar is smooth (average) over last values,
225225
so it differs from values set in train/validation step.
226226
"""
227-
warnings.warn('training_step must be implemented to be used with the Lightning Trainer')
227+
warnings.warn('`training_step` must be implemented to be used with the Lightning Trainer')
228228

229229
def training_end(self, *args, **kwargs):
230230
"""
@@ -1076,8 +1076,7 @@ def configure_optimizers(self):
10761076
}
10771077
10781078
"""
1079-
warnings.warn('configure_optimizers must be implemented to be used with the '
1080-
'Lightning Trainer')
1079+
warnings.warn('`configure_optimizers` must be implemented to be used with the Lightning Trainer')
10811080

10821081
def optimizer_step(
10831082
self,
@@ -1279,7 +1278,7 @@ def train_dataloader(self):
12791278
return loader
12801279
12811280
"""
1282-
warnings.warn('train_dataloader must be implemented to be used with the Lightning Trainer')
1281+
warnings.warn('`train_dataloader` must be implemented to be used with the Lightning Trainer')
12831282

12841283
def tng_dataloader(self): # todo: remove in v1.0.0
12851284
"""Implement a PyTorch DataLoader.

0 commit comments

Comments
 (0)