Skip to content

Commit 90f641a

Browse files
fixes logger crash on ddp (#2388)
* remove warnings * remove warnings * remove warnings * remove warnings * remove warnings * remove warnings * remove warnings * remove warnings * remove warnings * remove warnings
1 parent 41f5df1 commit 90f641a

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

pl_examples/models/lightning_template.py

-3
Original file line numberDiff line numberDiff line change
@@ -150,15 +150,12 @@ def setup(self, stage):
150150
self.mnist_test = MNIST(self.data_root, train=False, download=False, transform=transform)
151151

152152
def train_dataloader(self):
153-
log.info('Training data loader called.')
154153
return DataLoader(self.mnist_train, batch_size=self.batch_size, num_workers=4)
155154

156155
def val_dataloader(self):
157-
log.info('Validation data loader called.')
158156
return DataLoader(self.mnist_test, batch_size=self.batch_size, num_workers=4)
159157

160158
def test_dataloader(self):
161-
log.info('Test data loader called.')
162159
return DataLoader(self.mnist_test, batch_size=self.batch_size, num_workers=4)
163160

164161
@staticmethod

pytorch_lightning/trainer/callback_config.py

+2-7
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def configure_checkpoint_callback(self):
4242
ckpt_path = self.default_root_dir
4343
if self.checkpoint_callback:
4444
# init a default one
45-
if self.logger is not None:
45+
if self.logger is not None and self.logger.experiment is not None:
4646
save_dir = (getattr(self.logger, 'save_dir', None) or
4747
getattr(self.logger, '_save_dir', None) or
4848
self.default_root_dir)
@@ -53,12 +53,7 @@ def configure_checkpoint_callback(self):
5353

5454
version = self.logger.version if isinstance(
5555
self.logger.version, str) else f'version_{self.logger.version}'
56-
ckpt_path = os.path.join(
57-
save_dir,
58-
self.logger.name,
59-
version,
60-
"checkpoints"
61-
)
56+
ckpt_path = os.path.join(save_dir, self.logger.name, version, "checkpoints")
6257
else:
6358
ckpt_path = os.path.join(self.default_root_dir, "checkpoints")
6459

0 commit comments

Comments
 (0)