Skip to content

Commit 96eb6eb

Browse files
authored
fix shell injection vulnerability in subprocess call (#2786)
1 parent c600ca6 commit 96eb6eb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pytorch_lightning/trainer/training_io.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -226,11 +226,11 @@ def sig_handler(self, signum, frame): # pragma: no-cover
226226

227227
# find job id
228228
job_id = os.environ['SLURM_JOB_ID']
229-
cmd = 'scontrol requeue {}'.format(job_id)
229+
cmd = ['scontrol', 'requeue', job_id]
230230

231231
# requeue job
232232
log.info(f'requeing job {job_id}...')
233-
result = call(cmd, shell=True)
233+
result = call(cmd)
234234

235235
# print result text
236236
if result == 0:

0 commit comments

Comments
 (0)