Skip to content

Commit af44583

Browse files
authored
drop torchvision, tests only (#797)
* drop torchvision, tests only * manifest * move test utils
1 parent 8fa802e commit af44583

17 files changed

+40
-42
lines changed

MANIFEST.in

+1-3
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ exclude *.svg
1515
recursive-include pytorch_lightning *.py
1616

1717
# include examples
18-
recursive-include pl_examples *.py
19-
recursive-include pl_examples *.md
20-
recursive-include pl_examples *.sh
18+
recursive-include pl_examples *.py *.md *.sh *.txt
2119

2220
# exclude tests from package
2321
recursive-exclude tests *

pl_examples/requirements.txt

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
torchvision>=0.4.0

pytorch_lightning/testing/__init__.py

-12
This file was deleted.

pytorch_lightning/testing/model.py

-13
This file was deleted.

requirements.txt

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ scikit-learn>=0.20.2
22
tqdm>=4.35.0
33
numpy>=1.16.4
44
torch>=1.1
5-
torchvision>=0.4.0, < 0.5 # the 0.5. has some issues with torch JIT
65
tensorboard>=1.14
76
future>=0.17.1 # required for builtins in setup.py
87

tests/models/__init__.py

+24
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
"""Models for testing."""
2+
3+
import torch
4+
5+
from .base import LightningTestModelBase
6+
from .mixins import (
7+
LightningValidationStepMixin,
8+
LightningValidationMixin,
9+
LightningValidationStepMultipleDataloadersMixin,
10+
LightningValidationMultipleDataloadersMixin,
11+
LightningTestStepMixin,
12+
LightningTestMixin,
13+
LightningTestStepMultipleDataloadersMixin,
14+
LightningTestMultipleDataloadersMixin,
15+
)
16+
17+
18+
class LightningTestModel(LightningValidationMixin, LightningTestMixin, LightningTestModelBase):
19+
"""
20+
Most common test case. Validation and test dataloaders.
21+
"""
22+
23+
def on_training_metrics(self, logs):
24+
logs['some_tensor_to_test'] = torch.rand(1)
File renamed without changes.
File renamed without changes.
File renamed without changes.

tests/utils.py tests/models/utils.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from pytorch_lightning import Trainer
1010
from pytorch_lightning.callbacks import ModelCheckpoint
1111
from pytorch_lightning.loggers import TestTubeLogger, TensorBoardLogger
12-
from pytorch_lightning.testing import LightningTestModel
12+
from tests.models import LightningTestModel
1313

1414
# generate a list of random seeds for each test
1515
RANDOM_PORTS = list(np.random.randint(12000, 19000, 1000))

tests/requirements.txt

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
torchvision>=0.4.0, < 0.5 # the 0.5. has some issues with torch JIT
12
tox
23
coverage
34
codecov

tests/test_amp.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import pytest
44

5-
import tests.utils as tutils
5+
import tests.models.utils as tutils
66
from pytorch_lightning import Trainer
7-
from pytorch_lightning.testing import (
7+
from tests.models import (
88
LightningTestModel,
99
)
1010
from pytorch_lightning.utilities.debugging import MisconfigurationException

tests/test_cpu_models.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
import torch
44

5-
import tests.utils as tutils
5+
import tests.models.utils as tutils
66
from pytorch_lightning import Trainer, data_loader
77
from pytorch_lightning.callbacks import (
88
EarlyStopping,
99
)
10-
from pytorch_lightning.testing import (
10+
from tests.models import (
1111
LightningTestModel,
1212
LightningTestModelBase,
1313
LightningTestMixin,

tests/test_gpu_models.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
import pytest
44
import torch
55

6-
import tests.utils as tutils
6+
import tests.models.utils as tutils
77
from pytorch_lightning import Trainer
88
from pytorch_lightning.callbacks import (
99
ModelCheckpoint,
1010
)
1111
from pytorch_lightning.core import memory
12-
from pytorch_lightning.testing import (
12+
from tests.models import (
1313
LightningTestModel,
1414
)
1515
from pytorch_lightning.trainer.distrib_parts import (

tests/test_logging.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import pytest
55
import torch
66

7-
import tests.utils as tutils
7+
import tests.models.utils as tutils
88
from pytorch_lightning import Trainer
99
from pytorch_lightning.loggers import (
1010
LightningLoggerBase,
@@ -15,7 +15,7 @@
1515
WandbLogger,
1616
NeptuneLogger
1717
)
18-
from pytorch_lightning.testing import LightningTestModel
18+
from tests.models import LightningTestModel
1919

2020

2121
def test_testtube_logger(tmpdir):

tests/test_restore_models.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33

44
import torch
55

6-
import tests.utils as tutils
6+
import tests.models.utils as tutils
77
from pytorch_lightning import Trainer
88
from pytorch_lightning.callbacks import ModelCheckpoint
9-
from pytorch_lightning.testing import LightningTestModel
9+
from tests.models import LightningTestModel
1010

1111

1212
def test_running_test_pretrained_model_ddp(tmpdir):

tests/test_trainer.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
import pytest
44
import torch
55

6-
import tests.utils as tutils
6+
import tests.models.utils as tutils
77
from pytorch_lightning import Trainer
88
from pytorch_lightning.callbacks import (
99
ModelCheckpoint,
1010
)
11-
from pytorch_lightning.testing import (
11+
from tests.models import (
1212
LightningTestModel,
1313
LightningTestModelBase,
1414
LightningValidationStepMixin,

0 commit comments

Comments
 (0)