Skip to content

Commit fb6c33a

Browse files
arnaudgelasBorda
authored andcommitted
Fix pre-commit trailing-whitespace and end-of-file-fixer hooks. (#5387)
(cherry picked from commit 4c6f36e)
1 parent e1a4c2e commit fb6c33a

28 files changed

+125
-130
lines changed

.github/BECOMING_A_CORE_CONTRIBUTOR.md

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# How to become a core contributor
22

3-
Thanks for your interest in joining the Lightning team! We’re a rapidly growing project which is poised to become the go-to framework for DL researchers!
4-
We're currently recruiting for a team of 5 core maintainers.
3+
Thanks for your interest in joining the Lightning team! We’re a rapidly growing project which is poised to become the go-to framework for DL researchers!
4+
We're currently recruiting for a team of 5 core maintainers.
55

66
As a core maintainer you will have a strong say in the direction of the project. Big changes will require a majority of maintainers to agree.
77

8-
### Code of conduct
8+
### Code of conduct
99
First and foremost, you'll be evaluated against [these core values](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/.github/CONTRIBUTING.md). Any code we commit or feature we add needs to align with those core values.
1010

11-
### The bar for joining the team
11+
### The bar for joining the team
1212
Lightning is being used to solve really hard problems at the top AI labs in the world. As such, the bar for adding team members is extremely high. Candidates must have solid engineering skills, have a good eye for user experience, and must be a power user of Lightning and PyTorch.
1313

1414
With that said, the Lightning team will be diverse and a reflection of an inclusive AI community. You don't have to be an engineer to contribute! Scientists with great usability intuition and PyTorch ninja skills are welcomed!
@@ -36,26 +36,26 @@ Pleasant/helpful tone.
3636
- Code is NOT overly engineered or hard to read
3737
- Ask yourself, could a non-engineer understand what’s happening here?
3838
- Make sure new tests are written
39-
- Is this NECESSARY for Lightning? There are some PRs which are just purely about adding engineering complexity which have no place in Lightning.
39+
- Is this NECESSARY for Lightning? There are some PRs which are just purely about adding engineering complexity which have no place in Lightning.
4040
Guidance
4141
- Some other PRs are for people who are wanting to get involved and add something unnecessary. We do want their help though! So don’t approve the PR, but direct them to a Github issue that they might be interested in helping with instead!
42-
- To be considered for core contributor, please review 10 PRs and help the authors land it on master. Once you've finished the review, ping me
42+
- To be considered for core contributor, please review 10 PRs and help the authors land it on master. Once you've finished the review, ping me
4343
for a sanity check. At the end of 10 PRs if your PR reviews are inline with expectations described above, then you can merge PRs on your own going forward,
4444
otherwise we'll do a few more until we're both comfortable :)
4545

4646
#### Project directions
4747
There are some big decisions which the project must make. For these I expect core contributors to have something meaningful to add if it’s their area of expertise.
4848

4949
#### Diversity
50-
Lightning should reflect the broader community it serves. As such we should have scientists/researchers from
51-
different fields contributing!
50+
Lightning should reflect the broader community it serves. As such we should have scientists/researchers from
51+
different fields contributing!
5252

5353
The first 5 core contributors will fit this profile. Thus if you overlap strongly with experiences and expertise as someone else on the team, you might have to wait until the next set of contributors are added.
5454

5555
#### Summary: Requirements to apply
5656
The goal is to be inline with expectations for solving issues by the last one so you can do them on your own. If not, I might ask you to solve a few more specific ones.
5757

58-
- Solve 10+ Github issues.
58+
- Solve 10+ Github issues.
5959
- Create 5+ meaningful PRs which solves some reported issue - bug,
6060
- Perform 10+ PR reviews from other contributors.
6161

.github/ISSUE_TEMPLATE/documentation.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ assignees: ''
1212
For typos and doc fixes, please go ahead and:
1313

1414
1. Create an issue.
15-
2. Fix the typo.
15+
2. Fix the typo.
1616
3. Submit a PR.
1717

1818
Thanks!

.github/ISSUE_TEMPLATE/how-to-question.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@ assignees: ''
99

1010
## ❓ Questions and Help
1111

12-
### Before asking:
12+
### Before asking:
1313
1. Try to find answers to your questions in [the Lightning Forum!](https://forums.pytorchlightning.ai/)
14-
2. Search for similar [issues](https://github.com/PyTorchLightning/pytorch-lightning/issues).
15-
3. Search the [docs](https://pytorch-lightning.readthedocs.io/en/latest/).
14+
2. Search for similar [issues](https://github.com/PyTorchLightning/pytorch-lightning/issues).
15+
3. Search the [docs](https://pytorch-lightning.readthedocs.io/en/latest/).
1616

1717
<!-- If you still can't find what you need: -->
1818

1919
#### What is your question?
2020

2121
#### Code
2222

23-
<!-- Please paste a code snippet if your question requires it! -->
23+
<!-- Please paste a code snippet if your question requires it! -->
2424

2525
#### What have you tried?
2626

.github/workflows/docs-checks.yml

-1
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,3 @@ jobs:
109109
path: docs/build/html/
110110
# Use always() to always run this step to publish test results when there are test failures
111111
if: success()
112-

MANIFEST.in

-1
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,3 @@ prune temp*
6969
prune test*
7070
prune benchmark*
7171
prune dockers
72-

docs/.build_docs.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
rm -rf source/generated
22
make clean
3-
make html --debug --jobs 2 SPHINXOPTS="-W"
3+
make html --debug --jobs 2 SPHINXOPTS="-W"

docs/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ help:
1616
# Catch-all target: route all unknown targets to Sphinx using the new
1717
# "make mode" option. $(O) is meant as a shortcut for $(SPHINXOPTS).
1818
%: Makefile
19-
@$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)
19+
@$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)

docs/source/_static/main.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
col {
22
width: 50% !important;
3-
}
3+
}

0 commit comments

Comments
 (0)