Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should test the scheduler class instead of dict #1154

Closed
vincentzlt opened this issue Mar 15, 2020 · 2 comments
Closed

should test the scheduler class instead of dict #1154

vincentzlt opened this issue Mar 15, 2020 · 2 comments
Labels
bug Something isn't working
Milestone
pl:0.7.x

Comments

@vincentzlt
Copy link

https://github.com/PyTorchLightning/pytorch-lightning/blob/3ad6169f187ea41aa1534a1d9a3b978d053dca2b/pytorch_lightning/trainer/trainer.py#L711

isinstance(scheduler['scheduler'], optim.lr_scheduler.ReduceLROnPlateau)
@SkafteNicki
Copy link
Member

PR #1126 will fix this

@Borda Borda added the bug Something isn't working label Mar 18, 2020
@Borda Borda added this to the 0.7.2 milestone Mar 18, 2020
@SkafteNicki SkafteNicki mentioned this issue Mar 18, 2020
Merged
5 tasks
@SkafteNicki
Copy link
Member

@Borda this can be closed

@Borda Borda closed this as completed Mar 29, 2020
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
pl:0.7.x
Development

No branches or pull requests
3 participants
@Borda @vincentzlt @SkafteNicki