Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightningTemplateModel is broken #1546

Closed
festeh opened this issue Apr 21, 2020 · 2 comments · Fixed by #1577
Closed

LightningTemplateModel is broken #1546

festeh opened this issue Apr 21, 2020 · 2 comments · Fixed by #1577
Labels
bug Something isn't working help wanted Open to be worked on

Comments

@festeh
Copy link
Contributor

festeh commented Apr 21, 2020

🐛 Bug

LightningTemplateModel has no implemented validation_step_end method. See here

To Reproduce

Just try to run test evaluation on MNIST example

Expected behavoir

It should not crash
@festeh festeh added bug Something isn't working help wanted Open to be worked on labels Apr 21, 2020
@Borda
Copy link
Member

Borda commented Apr 21, 2020

@festeh mind draft a PR to fix it? 🐰

@festeh
Copy link
Contributor Author

festeh commented Apr 22, 2020

@Borda yes, will make it soon

@festeh festeh mentioned this issue Apr 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix LightningTemplateModel festeh/pytorch-lightning
2 participants
@Borda @festeh