Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name 'IProgress' is not defined #1687

Closed
drozzy opened this issue May 1, 2020 · 5 comments · Fixed by #2417
Closed

name 'IProgress' is not defined #1687

drozzy opened this issue May 1, 2020 · 5 comments · Fixed by #2417
Labels
bug Something isn't working help wanted Open to be worked on

Comments

@drozzy
Copy link

drozzy commented May 1, 2020

name 'IProgress' is not defined when running from Jupyter notebook.

@drozzy drozzy added bug Something isn't working help wanted Open to be worked on labels May 1, 2020
@olineumann
Copy link
Contributor

olineumann commented May 2, 2020

Did you try to install ipywidgets?

https://ipywidgets.readthedocs.io/en/latest/user_install.html

@williamFalcon
Copy link
Contributor

should we try catch this? and change usage + warn user when this happens?

@olineumann
Copy link
Contributor

Isn't it only tqdm.auto which uses ipywidgets to display a progress bar? That we only use here:
https://github.com/PyTorchLightning/pytorch-lightning/search?q=tqdm.auto&unscoped_q=tqdm.auto

Maybe it should be changed in tqdm.auto to not take IProgess if ipywidgets is not installed. There are already some checks:
https://github.com/tqdm/tqdm/blob/master/tqdm/autonotebook.py

But I had a similar problem when using jupyter lab and I had to install nodejs for it (which I wanted to avoid) but found no way of disable tqdm.auto taking IProgress. In my case it didn't crashed but no progress bar were displayed. If someone knows a way of overwriting the tqdm.auto selection let me know. Otherwise I think the checks should be better or there should be a way of overwriting the tqdm.auto selection. (In my opinion)

@drozzy
Copy link
Author

drozzy commented May 28, 2020

I am doing:
from tqdm import tqdm
and it seems to work.
In addition I had to install ipywidgets.

Perhaps pytorch-lightning should depend on ipywidgets? It seems like jupyter is a pretty common use case for people.

@Borda
Copy link
Member

Borda commented Jun 26, 2020

I do not think we want to add ipywidgets as dependency bu we can do similar check on our side too
@olineumann mind send PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Open to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants