Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .comet.config file for CometLogger #1810

Closed
neighthan opened this issue May 13, 2020 · 4 comments · Fixed by #1913
Closed

Use .comet.config file for CometLogger #1810

neighthan opened this issue May 13, 2020 · 4 comments · Fixed by #1913
Assignees
Labels
feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on

Comments

@neighthan
Copy link
Contributor

neighthan commented May 13, 2020

🚀 Feature

When creating a CometML experiment normally, the API key will be read from the file ~/.comet.config or from an environment variable if it isn't passed in directly. It would be nice if the CometLogger supported these uses as well.

Motivation

Putting the API key in code is certainly a bad practice, and it's a pain to have to export it as an environment variable and then get its value in Python or else read it from the file manually. Adding this feature makes things more seamless compared to how people use CometML when not using PyTorch Lightning.

Additional context

I have a patch written for this already; it only changes a few lines of code. From the template message when I went to create a PR, though, it seemed I should create an issue first. Let me know if you have thoughts about this.

(somewhat related - the REST API key is also deprecated; the normal API key should be used instead now. I didn't change that code, though, because I'm not sure if older versions of Comet would have any issues with that change.)

@neighthan neighthan added feature Is an improvement or enhancement help wanted Open to be worked on labels May 13, 2020
@github-actions
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@rohitgr7
Copy link
Contributor

@Borda Can this be fixed?? This makes easy to work with CometLogger.

@Borda
Copy link
Member

Borda commented May 20, 2020

@neighthan cool mind send the PR?

@stale
Copy link

stale bot commented Jul 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jul 19, 2020
@stale stale bot closed this as completed Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants