Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absolute/relative imports #459

Closed
Borda opened this issue Nov 5, 2019 · 2 comments
Closed

absolute/relative imports #459

Borda opened this issue Nov 5, 2019 · 2 comments
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@Borda
Copy link
Member

Borda commented Nov 5, 2019

@williamFalcon suggest using absolute import inside the package #402 (comment)
I would like to discuss a bit on the advantages/drawback of both since I have seen more often relative imports then the absolute, for example, scikit-learn

See:

@Borda Borda added feature Is an improvement or enhancement help wanted Open to be worked on labels Nov 5, 2019
@williamFalcon
Copy link
Contributor

@Borda let's chat on the forum but i lean on keeping them absolute again, since it's clear where the import comes from.

@Borda
Copy link
Member Author

Borda commented Dec 4, 2019

ok, my thought was that with relative imports it does not interfere with already (locally) installed version while you are running tests and some function/module/package changed in developed version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants