Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map_location hasn't been implemented in load_from_checkpoint #600

Closed
haossr opened this issue Dec 6, 2019 · 3 comments · Fixed by #625
Closed

map_location hasn't been implemented in load_from_checkpoint #600

haossr opened this issue Dec 6, 2019 · 3 comments · Fixed by #625
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@haossr
Copy link
Contributor

haossr commented Dec 6, 2019

Describe the bug
Current load_from_checkpoint function does not support to load a gpu checkpoint on cpu devices, i.e. map the location.

To Reproduce

# on a cpu only device:
Model.load_from_checkpoint("GPU_CHECKPOINT_FILE")

Expected behavior
AssertionError: Torch not compiled with CUDA enabled

Desktop (please complete the following information):

  • OS: macOS Catalina 10.15.1
  • Browser: chrome
  • Version: 0.5.3.1
@haossr haossr added the bug Something isn't working label Dec 6, 2019
@williamFalcon
Copy link
Contributor

weird, i thought we did. mind submitting a PR?

@williamFalcon williamFalcon added feature Is an improvement or enhancement help wanted Open to be worked on and removed bug Something isn't working labels Dec 7, 2019
@haossr
Copy link
Contributor Author

haossr commented Dec 7, 2019

Sure will do.

@haossr haossr mentioned this issue Dec 13, 2019
Merged
@gaoalexander
Copy link

This appears to still be unresolved, currently using Lightning 2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix of issue 600 haossr/pytorch-lightning
3 participants
@williamFalcon @haossr @gaoalexander