-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slim down progress bar default printing #629
Comments
great suggestion. let's make all the changes you suggested except:
Submit a PR when ready! |
Yeah great suggestion. This is something i've been thinking about as my tqdm dictionaries tend to be pretty big. @williamFalcon, what's your reasoning for keeping loss? One issue I have with the default loss is that it only displays with 3 precision numbers so I have to put it in the tqdm anyway. Of course, that could be fixed in other ways but this seems like a decent solution. I'd suggest keeping loss as a default only when the tqdm dictionary isn't supplied. I'd like to hear your justification on keeping v_nb too. It does seem wasteful considering it's constant throughout training. |
I would be as lean as possible with the defaults because it is quite easy for the user to add stuff, while it is impossible to remove the defaults.
I like this proposal: with a "default" tqdm_dict that we can override we achieve both convenience and full flexibility |
@CarloLucibello @tullie want to submit a PR? |
🚀 Feature
The progress bar is cluttered, too many prints by default. Let's remove some of them.
Pitch
Hi guys,
I feel the progress bar contains some uninformative prints and leaves little space for user customization.
This is the progress bar print before validation, with empty tqdm_dict (so no user addition to the progress bar metrics):
This is after a validation step where I add to the tqdm_dict validation accuracy and loss:
To avoid more clutter and make some room for user-defined metrics, I propose to remove the following outputs from the progress bar:
Also, I propose to rename "batch/s" to tqdm default "it/s" to save a few extra characters.
Pinging @tullie @Borda since this discussion almost started in #531 .
Best,
C
The text was updated successfully, but these errors were encountered: