Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune crashes with DataModule #6845

Closed
lukasfolle opened this issue Apr 6, 2021 · 1 comment
Closed

Tune crashes with DataModule #6845

lukasfolle opened this issue Apr 6, 2021 · 1 comment
Labels
bug Something isn't working help wanted Open to be worked on

Comments

@lukasfolle
Copy link

🐛 Bug

Connected to #1495.
When using trainer.tune() only the model is forwarded, but no the datamodule cp.: https://github.com/PyTorchLightning/pytorch-lightning/blob/eafec7d425bf691ab5bfaf2794c3e581487ecfa8/pytorch_lightning/tuner/tuning.py#L64

Expected behavior

Just like for self.trainer.auto_scale_batch_size the datamodule or train/val dataloaders should be forwarded as well.
I.e.:

self.lr_find(
  model,
  train_dataloader=train_dataloader,
  val_dataloaders=val_dataloaders,
  datamodule=datamodule, ...)
@lukasfolle lukasfolle added bug Something isn't working help wanted Open to be worked on labels Apr 6, 2021
@lukasfolle lukasfolle mentioned this issue Apr 6, 2021
Closed
@SkafteNicki
Copy link
Member

Fixed by #6784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SkafteNicki @lukasfolle