From da7045ba4456c944e0742713a834fa042984c13c Mon Sep 17 00:00:00 2001 From: ybrovman Date: Wed, 22 Apr 2020 11:06:10 -0400 Subject: [PATCH 1/3] removed if dl from _reset_eval_dataloader() --- pytorch_lightning/trainer/data_loading.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytorch_lightning/trainer/data_loading.py b/pytorch_lightning/trainer/data_loading.py index b3e15024c45de..69bba81061d11 100644 --- a/pytorch_lightning/trainer/data_loading.py +++ b/pytorch_lightning/trainer/data_loading.py @@ -219,7 +219,7 @@ def _reset_eval_dataloader(self, model: LightningModule, mode: str) -> Tuple[int ' this off for validation and test dataloaders.') # add samplers - dataloaders = [self.auto_add_sampler(dl, train=False) for dl in dataloaders if dl] + dataloaders = [self.auto_add_sampler(dl, train=False) for dl in dataloaders] num_batches = 0 From b5ff5282c17891212b01f689c80f501d59d23b37 Mon Sep 17 00:00:00 2001 From: ybrovman Date: Wed, 22 Apr 2020 20:00:34 -0400 Subject: [PATCH 2/3] changed to if dl != None to be more safe --- pytorch_lightning/trainer/data_loading.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytorch_lightning/trainer/data_loading.py b/pytorch_lightning/trainer/data_loading.py index 69bba81061d11..82e3620d3345e 100644 --- a/pytorch_lightning/trainer/data_loading.py +++ b/pytorch_lightning/trainer/data_loading.py @@ -219,7 +219,7 @@ def _reset_eval_dataloader(self, model: LightningModule, mode: str) -> Tuple[int ' this off for validation and test dataloaders.') # add samplers - dataloaders = [self.auto_add_sampler(dl, train=False) for dl in dataloaders] + dataloaders = [self.auto_add_sampler(dl, train=False) for dl in dataloaders if dl != None] num_batches = 0 From 6e805a0246cd3a13ec110004e936426a00238fa7 Mon Sep 17 00:00:00 2001 From: ybrovman Date: Wed, 22 Apr 2020 20:06:32 -0400 Subject: [PATCH 3/3] hints from pep8speaks --- pytorch_lightning/trainer/data_loading.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytorch_lightning/trainer/data_loading.py b/pytorch_lightning/trainer/data_loading.py index 82e3620d3345e..fb82c70b31bb5 100644 --- a/pytorch_lightning/trainer/data_loading.py +++ b/pytorch_lightning/trainer/data_loading.py @@ -219,7 +219,7 @@ def _reset_eval_dataloader(self, model: LightningModule, mode: str) -> Tuple[int ' this off for validation and test dataloaders.') # add samplers - dataloaders = [self.auto_add_sampler(dl, train=False) for dl in dataloaders if dl != None] + dataloaders = [self.auto_add_sampler(dl, train=False) for dl in dataloaders if dl is not None] num_batches = 0