From 0742daf9abffd67d46146f7845670af51d67bb6d Mon Sep 17 00:00:00 2001 From: Tullie Murrell Date: Mon, 8 Jun 2020 17:20:29 -0700 Subject: [PATCH 1/2] Remove explicit flush from tensorboard logger --- pytorch_lightning/loggers/tensorboard.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pytorch_lightning/loggers/tensorboard.py b/pytorch_lightning/loggers/tensorboard.py index 62965d783231c..12ce47398d3b3 100644 --- a/pytorch_lightning/loggers/tensorboard.py +++ b/pytorch_lightning/loggers/tensorboard.py @@ -144,12 +144,6 @@ def log_metrics(self, metrics: Dict[str, float], step: Optional[int] = None) -> @rank_zero_only def save(self) -> None: super().save() - try: - self.experiment.flush() - except AttributeError: - # you are using PT version ( Date: Mon, 8 Jun 2020 17:33:22 -0700 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 321319d6a216c..9eff33065f21d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). ### Added +- Remove explicit flush from tensorboard logger ([#2126] https://github.com/PyTorchLightning/pytorch-lightning/pull/2126) + - Add Metric Base Classes ([#1326](https://github.com/PyTorchLightning/pytorch-lightning/pull/1326), [#1877](https://github.com/PyTorchLightning/pytorch-lightning/pull/1877)) - Added type hints in `Trainer.fit()` and `Trainer.test()` to reflect that also a list of dataloaders can be passed in ([#1723](https://github.com/PyTorchLightning/pytorch-lightning/pull/1723))