fs: fix rmsync error swallowing

fix rmsync swallowing errors instead of throwing them.

fixes: nodejs#38683

Author: Linkgoron

lib/internal/fs/rimraf.js

@@ -219,6 +219,12 @@ function _unlinkSync(path, options) {
           i < tries &&
           options.retryDelay > 0) {
         sleep(i * options.retryDelay);
+      } else {
+        // The file is already gone.
+        if (err.code === 'ENOENT') {
+          return;
+        }
+        throw err;
       }
     }
   }
@@ -259,10 +265,18 @@ function _rmdirSync(path, options, originalErr) {
               i < tries &&
               options.retryDelay > 0) {
             sleep(i * options.retryDelay);
+          } else {
+            // The file is already gone.
+            if (err.code === 'ENOENT') {
+              return;
+            }
+            throw err;
           }
         }
       }
     }
+
+    throw originalErr;
   }
 }
 

test/parallel/test-fs-rm.js

@@ -280,3 +280,24 @@ function removeAsync(dir) {
     message: /^The value of "options\.maxRetries" is out of range\./
   });
 }
+
+{
+  // Check the deleting a file that cannot be accessed using rmsync throws
+  const dirname = nextDirPath();
+  try {
+    fs.mkdirSync(dirname, { recursive: true });
+    fs.writeFileSync(path.join(dirname, 'text.txt'), 'hello');
+    fs.chmodSync(dirname, '500');
+    assert.throws(() => {
+      fs.rmSync(`${dirname}/text.txt`, { force: true });
+    }, {
+      code: 'EACCES',
+      syscall: 'unlink',
+      name: 'Error',
+      errno: -13,
+    });
+  } finally {
+    fs.chmodSync(dirname, '777');
+    fs.rmSync(`${dirname}/text.txt`, { force: true });
+  }
+}