Enable mid-absorption ISF, and update forecast on settings change (#715)

Author: ps2

Loop/Managers/LoopDataManager.swift

@@ -225,6 +225,19 @@ final class LoopDataManager: ObservableObject {
                     await self.updateDisplayState()
                     self.notify(forChange: .insulin)
                 }
+            },
+            NotificationCenter.default.addObserver(
+                forName: .LoopDataUpdated,
+                object: nil,
+                queue: nil
+            ) { (note) in
+                let context = note.userInfo?[LoopDataManager.LoopUpdateContextKey] as! LoopUpdateContext.RawValue
+                if case .preferences = LoopUpdateContext(rawValue: context) {
+                    Task { @MainActor in
+                        self.logger.default("Received notification of settings changing")
+                        await self.updateDisplayState()
+                    }
+                }
             }
         ]
 
@@ -435,8 +448,7 @@ final class LoopDataManager: ObservableObject {
             carbAbsorptionModel: carbAbsorptionModel,
             recommendationInsulinModel: insulinModel(for: deliveryDelegate?.pumpInsulinType ?? .novolog),
             recommendationType: .manualBolus,
-            automaticBolusApplicationFactor: effectiveBolusApplicationFactor,
-            useMidAbsorptionISF: false)
+            automaticBolusApplicationFactor: effectiveBolusApplicationFactor)
     }
 
     func loopingReEnabled() async {

Loop/Models/StoredDataAlgorithmInput.swift

@@ -52,5 +52,5 @@ struct StoredDataAlgorithmInput: AlgorithmInput {
 
     var automaticBolusApplicationFactor: Double?
 
-    var useMidAbsorptionISF: Bool
+    let useMidAbsorptionISF: Bool = true
 }

LoopTests/Managers/MealDetectionManagerTests.swift

@@ -234,9 +234,7 @@ class MealDetectionManagerTests: XCTestCase {
             includePositiveVelocityAndRC: true,
             carbAbsorptionModel: .piecewiseLinear,
             recommendationInsulinModel: ExponentialInsulinModelPreset.rapidActingAdult.model,
-            recommendationType: .automaticBolus,
-            useMidAbsorptionISF: false
-        )
+            recommendationType: .automaticBolus)
 
         // These tests don't actually run the loop algorithm directly; they were written to take ICE from fixtures, compute carb effects, and subtract them.
         let counteractionEffects = counteractionEffects(for: testType)

LoopTests/ViewModels/BolusEntryViewModelTests.swift

@@ -867,8 +867,7 @@ fileprivate class MockBolusEntryViewModelDelegate: BolusEntryViewModelDelegate {
         carbAbsorptionModel: .piecewiseLinear,
         recommendationInsulinModel: ExponentialInsulinModelPreset.rapidActingAdult,
         recommendationType: .manualBolus,
-        automaticBolusApplicationFactor: 0.4,
-        useMidAbsorptionISF: false
+        automaticBolusApplicationFactor: 0.4
     )
 
     func fetchData(for baseTime: Date, disablingPreMeal: Bool, ensureDosingCoverageStart: Date?) async throws -> StoredDataAlgorithmInput {