Merge remote-tracking branch 'upstream/master'

Author: LouisBrunner

.gitignore

@@ -43,6 +43,7 @@
 # /auxprogs/
 /auxprogs/.deps
 /auxprogs/getoff-amd64-darwin
+/auxprogs/getoff-arm-linux
 /auxprogs/getoff-arm64-linux
 /auxprogs/getoff-x86-darwin
 /auxprogs/getoff-amd64-linux
@@ -106,6 +107,7 @@
 /cachegrind/tests/cachegrind.out.*
 /cachegrind/tests/chdir
 /cachegrind/tests/clreq
+/cachegrind/tests/clreq2
 /cachegrind/tests/dlclose
 /cachegrind/tests/wrap5
 
@@ -480,6 +482,7 @@
 /drd/tests/tc22_exit_w_lock
 /drd/tests/tc23_bogus_condwait
 /drd/tests/tc24_nonzero_sem
+/drd/tests/thrd_create
 /drd/tests/threaded-fork
 /drd/tests/thread_name
 /drd/tests/thread_name_freebsd
@@ -531,7 +534,15 @@
 /exp-bbv/tests/amd64-linux/rep_prefix
 
 # /exp-bbv/tests/arm-linux/
+/exp-bbv/tests/arm-linux/*.post.diff
+/exp-bbv/tests/arm-linux/*.post.out
+/exp-bbv/tests/arm-linux/*.stderr.diff
+/exp-bbv/tests/arm-linux/*.stderr.out
+/exp-bbv/tests/arm-linux/*.stdout.diff
+/exp-bbv/tests/arm-linux/*.stdout.out
 /exp-bbv/tests/arm-linux/.deps
+/exp-bbv/tests/arm-linux/ll
+/exp-bbv/tests/arm-linux/million
 /exp-bbv/tests/arm-linux/Makefile
 /exp-bbv/tests/arm-linux/Makefile.in
 
@@ -845,6 +856,7 @@
 /memcheck/tests/bug287260
 /memcheck/tests/bug340392
 /memcheck/tests/bug464969_d_demangle
+/memcheck/tests/bug472219
 /memcheck/tests/calloc-overflow
 /memcheck/tests/cdebug_zlib
 /memcheck/tests/cdebug_zlib_gnu
@@ -865,6 +877,7 @@
 /memcheck/tests/descr_belowsp
 /memcheck/tests/dir
 /memcheck/tests/doublefree
+/memcheck/tests/duplicate_align_size_errors
 /memcheck/tests/dw4
 /memcheck/tests/erringfds
 /memcheck/tests/error_counts
@@ -931,6 +944,8 @@
 /memcheck/tests/nanoleak
 /memcheck/tests/nanoleak2
 /memcheck/tests/nanoleak_supp
+/memcheck/tests/new_aligned_delete_default
+/memcheck/tests/new_delete_mismatch_size
 /memcheck/tests/new_nothrow
 /memcheck/tests/new_override
 /memcheck/tests/noisy_child
@@ -970,7 +985,9 @@
 /memcheck/tests/sh-mem
 /memcheck/tests/sh-mem-random
 /memcheck/tests/sized_aligned_new_delete_args
-/memcheck/tests/sized_aligned_new_delete_misaligned
+/memcheck/tests/sized_aligned_new_delete_misaligned1
+/memcheck/tests/sized_aligned_new_delete_misaligned2
+/memcheck/tests/sized_aligned_new_delete_misaligned3
 /memcheck/tests/sigaltstack
 /memcheck/tests/sigkill
 /memcheck/tests/signal2
@@ -1009,6 +1026,7 @@
 /memcheck/tests/wcs
 /memcheck/tests/weirdioctl
 /memcheck/tests/with space
+/memcheck/tests/wcsncpy
 /memcheck/tests/wmemcmp
 /memcheck/tests/wrap1
 /memcheck/tests/wrap2
@@ -1045,6 +1063,7 @@
 /memcheck/tests/amd64/insn-bsfl
 /memcheck/tests/amd64/insn-pmovmskb
 /memcheck/tests/amd64/insn-pcmpistri
+/memcheck/tests/amd64/pcmpgt
 /memcheck/tests/amd64/sh-mem-vec128
 /memcheck/tests/amd64/sh-mem-vec256
 /memcheck/tests/amd64/xsave-avx
@@ -1190,6 +1209,7 @@
 /memcheck/tests/s390x/Makefile
 /memcheck/tests/s390x/Makefile.in
 /memcheck/tests/s390x/cdsg
+/memcheck/tests/s390x/cli
 /memcheck/tests/s390x/cu21
 /memcheck/tests/s390x/cu42
 /memcheck/tests/s390x/ltgjhe
@@ -1283,6 +1303,7 @@
 /memcheck/tests/x86/fxsave
 /memcheck/tests/x86/int3-x86
 /memcheck/tests/x86/more_x86_fp
+/memcheck/tests/x86/pcmpgt
 /memcheck/tests/x86/pushfpopf
 /memcheck/tests/x86/pushfw_x86
 /memcheck/tests/x86/pushpopmem
@@ -1340,11 +1361,14 @@
 /memcheck/tests/freebsd/Makefile.in
 /memcheck/tests/freebsd/452275
 /memcheck/tests/freebsd/access
+/memcheck/tests/freebsd/aligned_alloc
 /memcheck/tests/freebsd/bug464476
 /memcheck/tests/freebsd/bug470713
 /memcheck/tests/freebsd/capsicum
 /memcheck/tests/freebsd/chflags
 /memcheck/tests/freebsd/chmod_chown
+/memcheck/tests/freebsd/close_range
+/memcheck/tests/freebsd/delete_sized_mismatch
 /memcheck/tests/freebsd/errno_aligned_allocs
 /memcheck/tests/freebsd/eventfd1
 /memcheck/tests/freebsd/eventfd2
@@ -1357,6 +1381,8 @@
 /memcheck/tests/freebsd/getfsstat
 /memcheck/tests/freebsd/inlinfo
 /memcheck/tests/freebsd/inlinfo_nested.so
+/memcheck/tests/freebsd/kqueue
+/memcheck/tests/freebsd/kqueuex
 /memcheck/tests/freebsd/linkat
 /memcheck/tests/freebsd/memalign
 /memcheck/tests/freebsd/misc
@@ -1365,6 +1391,7 @@
 /memcheck/tests/freebsd/revoke
 /memcheck/tests/freebsd/scalar
 /memcheck/tests/freebsd/scalar_13_plus
+/memcheck/tests/freebsd/scalar_15_plus
 /memcheck/tests/freebsd/scalar_abort2
 /memcheck/tests/freebsd/scalar_fork
 /memcheck/tests/freebsd/scalar_pdfork
@@ -1377,6 +1404,8 @@
 /memcheck/tests/freebsd/stat
 /memcheck/tests/freebsd/statfs
 /memcheck/tests/freebsd/static_allocs
+/memcheck/tests/freebsd/timerfd
+/memcheck/tests/freebsd/timing_safe
 /memcheck/tests/freebsd/utimens
 /memcheck/tests/freebsd/utimes
 
@@ -1692,9 +1721,31 @@
 /none/tests/amd64-solaris/syscall_return_args
 
 # /none/tests/arm/
+/none/tests/arm/*.stderr.diff
+/none/tests/arm/*.stderr.out
+/none/tests/arm/*.stdout.diff
+/none/tests/arm/*.stdout.out
 /none/tests/arm/.deps
 /none/tests/arm/Makefile
 /none/tests/arm/Makefile.in
+/none/tests/arm/allexec
+/none/tests/arm/intdiv
+/none/tests/arm/ldrt
+/none/tests/arm/ldrt_arm
+/none/tests/arm/neon128
+/none/tests/arm/neon64
+/none/tests/arm/v6intARM
+/none/tests/arm/v6intThumb
+/none/tests/arm/v6media
+/none/tests/arm/v8crypto_a
+/none/tests/arm/v8crypto_t
+/none/tests/arm/v8fpsimd_a
+/none/tests/arm/v8fpsimd_t
+/none/tests/arm/v8memory_a
+/none/tests/arm/v8memory_t
+/none/tests/arm/vcvt_fixed_float_VFP
+/none/tests/arm/vfp
+/none/tests/arm/vfpv4_fma
 
 # /none/tests/arm64/
 /none/tests/arm64/.deps

Makefile.tool.am

@@ -78,7 +78,7 @@ TOOL_LDFLAGS_ARM64_LINUX = \
 	$(TOOL_LDFLAGS_COMMON_LINUX) @FLAG_M64@
 
 TOOL_LDFLAGS_S390X_LINUX = \
-	$(TOOL_LDFLAGS_COMMON_LINUX) @FLAG_M64@
+	$(TOOL_LDFLAGS_COMMON_LINUX) @FLAG_M64@ @FLAG_S390_PGSTE@
 
 TOOL_LDFLAGS_X86_DARWIN = \
 	$(TOOL_LDFLAGS_COMMON_DARWIN) -arch i386

NEWS

@@ -12,17 +12,39 @@ AMD64/macOS 10.13 and nanoMIPS/Linux.
 
 * A new configure option --with-gdbscripts-dir lets you install
   the gdb valgrind python monitor scripts in a specific location.
-  For example an distro could use it to install the scripts in a
+  For example a distro could use it to install the scripts in a
   safe load location --with-gdbscripts-dir=%{_datadir}/gdb/auto-load
   It is also possible to configure --without-gdb-scripts-dir so no
   .debug_gdb_scripts section is added to the vgpreload library and
   no valgrind-monitor python scripts are installed at all.
 
 * ================== PLATFORM CHANGES =================
 
+* Support has been added for FreeBSD 14 and FreeBSD 15.
+* Add support for the folllowing FreeBSD system calls:
+  close_range, kqueuex, membarrier, timerfd_create,
+  timerfd_settime and timerfd_gettime (all added in FreeBSD 15).
 
 * ==================== TOOL CHANGES ===================
 
+* Memcheck now tests and warns about the values used for
+  alignment and size. These apply to various functions: memalign,
+  posix_memalign and aligned_alloc in C and various overloads
+  of operators new and delete in C++. The kinds of error that can
+  be detected are
+  - invalid alignment, for instance the alignment is usually required
+    to be a power of 2
+  - mismatched alignment between aligned allocation and aligned
+    deallocation
+  - mismatched size when sized delete is used
+  - bad size for functions that have implementation defined behaviour
+    when the requested size is zero
+
+* Cachegrind:
+  - You can now profile part of a program's execution using the new
+    `CACHEGRIND_START_INSTRUMENTATION` and `CACHEGRIND_STOP_INSTRUMENTATION`
+    client requests, along with the new `--instr-at-start` option. The
+    behaviour is the same as Callgrind's equivalent functionality.
 
 * ==================== FIXED BUGS ====================
 
@@ -33,21 +55,49 @@ bugzilla (https://bugs.kde.org/enter_bug.cgi?product=valgrind) rather
 than mailing the developers (or mailing lists) directly -- bugs that
 are not entered into bugzilla tend to get forgotten about or ignored.
 
+390871  ELF debug info reader confused with multiple .rodata* sections
+426751  Valgrind reports "still reachable" memory using musl (alpine running inside docker)
+432801  Valgrind 3.16.1 reports a jump based on uninitialized memory somehow related to clang and signals
+433857  Add validation to C++17 aligned new/delete alignment size
+433859  Add mismatched detection to C++ 17 aligned new/delete
 460192  Add epoll_pwait2
+461074  DWARF2 CFI reader: unhandled DW_OP_ 0x11 (consts) DW_OP_ 0x92 (bregx)
+465782  s390x: Valgrind doesn't compile with Clang on s390x
+466105  aligned_alloc problems, part 2
+467441  Add mismatched detection to C++ 14 sized delete
 469049  link failure on ppc64 (big endian) valgrind 3.20
 469146  massif --ignore-fn does not ignore inlined functions
 469768  Make it possible to install gdb scripts in a different location
 470121  Can't run callgrind_control with valgrind 3.21.0 because of perl errors
+470132  s390x: Assertion failure on VGM instruction
 470520  Multiple realloc zero errors crash in MC_(eq_Error)
 470713  Failure on the Yosys project: valgrind: m_libcfile.c:1802
         (Bool vgPlain_realpath(const HChar *, HChar *)):
         Assertion 'resolved' failed
 470830  Don't print actions vgdb me ... continue for vgdb --multi mode
+470978  s390x: Valgrind cannot start qemu-kvm when "sysctl vm.allocate_pgste=0"
+471311  gdb --multi mode stdout redirecting to stderr
+471807  Add support for lazy reading and downloading of DWARF debuginfo
+472219  Syscall param ppoll(ufds.events) points to uninitialised byte(s)
+472875  none/tests/s390x/dfp-1 failure 
+472963  Broken regular expression in configure.ac
+473604  Fix bug472219.c compile failure with Clang 16
+473677  make check compile failure with Clang 16 based on GCC 13.x
+473745  must-be-redirected function - strlen
+473870  FreeBSD 14 applications fail early at startup
+473944  Handle mold linker split RW PT_LOAD segments correctly
+474332  aligned_alloc under Valgrind returns nullptr when alignment is not a multiple of sizeof(void *)
+475650  DRD does not work with C11 threads
+475652  Missing suppression for __wcsncpy_avx2 (strncpy-avx2.S:308)?
+n-i-bz  Allow arguments with spaces in .valgrindrc files
+n-i-bz  FreeBSD fixed reading of Valgrind tools own debuginfo
 
 To see details of a given bug, visit
   https://bugs.kde.org/show_bug.cgi?id=XXXXXX
 where XXXXXX is the bug number as listed above.
 
+(3.22.0.RC1: 17 Oct 2023)
+
 Release 3.21.0 (28 Apr 2023)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 

README.freebsd

@@ -1,26 +1,37 @@
 Installing from ports or via pkg
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-If you are using FreeBSD 11.3 or later, then you should be able to install
-Valgrind using either
+You can install Valgrind using either
 
 pkg install devel/valgrind
 
 or alternatively from ports (if installed)
 
 cd /usr/ports/devel/valgrind && make install clean
 
+devel/valgrind is updated with official releases of Valgrind, normally
+in April and October each year. There is an alternative port,
+devel/valgrind-devel which occasionally gets updated from the latest
+Valgrind source. If you want to have the latest port, check on
+https://www.freshports.org/ to see which is the most recent. If you
+want to have the very latest version, you will need to build a copy
+from source. See README for instructions on getting the source with git.
+
 
 Building Valgrind
 ~~~~~~~~~~~~~~~~~
 
-Install ports for autoconf, automake, libtool and gmake.
+Install ports for autotools, gmake and python.
 
 $ sh autogen.sh
 $ ./configure --prefix=/where/ever
 $ gmake
 $ gmake install
 
+If you are using a jail for building, make sure that it is configured so that
+"uname -r" returns a string that matches the pattern "XX.Y-*" where XX is the
+major version (12, 13, 14 ...) and Y is the minor version (0, 1, 2, 3).
+
 Known Limitations (June 2022)
 
 0. Be aware that if you use a wrapper script and run Valgrind on the wrapper
@@ -126,20 +137,33 @@ These are much easier.
 
 They just contain a POST_MEM_WRITE macro for each output argument.
 
-1. Running regression tests
+1. Frequent causes of problems
+
+- New _umtx_op codes. Valgrind will print "WARNING: _umtx_op unsupported value".
+  See syswrap-freebsd.c and add new cases for the new codes.
+- Additions to auxv. Depending on the entry it may need to be simply copied
+  from the host to the guest, it may need to be modified for the guest or
+  it may need to be ignored. See initimg-freebsd.c.
+- ELF PT_LOAD mappings. Either Valgrind will assert or there will be no source
+  information in error reports. See VG_(di_notify_mmap) in debuginfo.c
+- Because they contain many deliberate errors the regression tests are prone
+  to change with changes of compiler. Liberal use of 'volatile' and
+  '-Wno-warning-flag' can help - see configure.ac
+
+2. Running regression tests
 
 In order to run all of the regression tests you will need to install
 the following packages
 gdb
 gsed
 
-In addition to running "make" you will need to run
-"make check" to build the regression test exectutables
-and "make regtest".  Again, more details can be seen in
+In addition to running "gmake" you will need to run
+"gmake check" to build the regression test exectutables
+and "gmake regtest".  Again, more details can be seen in
 README_DEVELOPERS.
 
 If you want to run the 'nightly' script (see nightly/README.txt)
-you will need to install coreutils and modify the
+you will need to install coreutils (for GNU cp) and modify the
 nightly/conf/freebsd.* files. The default configuration
 sends an e-mail to the valgrind-testresults mailing list.
 

README_DEVELOPERS

@@ -172,6 +172,13 @@ A different and possibly easier way is as follows:
     will continue as normal.  Note that comment (3) above re passing
     signals applies here too.
 
+The default build of Valgrind uses "-g -O2". This is OK most of the
+time, but with sophisticated optimization it can be difficult to
+see the contents of variables. A quick way to get to see function
+variables is to temporarily add "__attribute__((optnone))" before
+the function definition and rebuild. Alternatively modify
+Makefile.all.am and remove -O2 from AM_CFLAGS_BASE. That will
+require you to reconfigure and rebuild Valgrind.
 
 Self-hosting
 ~~~~~~~~~~~~