Skip to content

feat: Emit a warning if a type is marked as NeverClone but it implements the Copy trait #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LukeMathWalker opened this issue Dec 12, 2024 · 1 comment
Open

feat: Emit a warning if a type is marked as NeverClone but it implements the Copy trait #393

LukeMathWalker opened this issue Dec 12, 2024 · 1 comment
Labels
diagnostics Improvement or issue with Pavex's CLI diagnostics. enhancement New feature or request good first issue Good for newcomers p-pavexc Issue related to the pavexc crate

Comments

@LukeMathWalker
Copy link
Owner

LukeMathWalker commented Dec 12, 2024 •
edited
Loading

This is a good first issue for those who want to start working on pavexc, the compiler side of Pavex.

If you're interested in tackling it, comment here to claim it and I'll be happy to provide guidance.
@LukeMathWalker LukeMathWalker added enhancement New feature or request good first issue Good for newcomers diagnostics Improvement or issue with Pavex's CLI diagnostics. p-pavexc Issue related to the pavexc crate labels Dec 12, 2024
@donmai-me donmai-me mentioned this issue Feb 8, 2025
Open
@donmai-me
Copy link
Contributor

donmai-me commented Feb 8, 2025 •
edited
Loading

Hi! I just submitted a pr that hopefully implements this feature. I just mostly copied code from clonables_can_be_cloned function. Any feedback is welcome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diagnostics Improvement or issue with Pavex's CLI diagnostics. enhancement New feature or request good first issue Good for newcomers p-pavexc Issue related to the pavexc crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LukeMathWalker @donmai-me