Skip to content

Commit 01771ff

Browse files
Rollup merge of rust-lang#58199 - clintfred:partial-move-err-msg, r=estebank
Add better error message for partial move closes rust-lang#56657 r? @davidtwco
2 parents d9f3e58 + de05548 commit 01771ff

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

src/librustc_mir/borrow_check/error_reporting.rs

+8-2
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,11 @@ impl<'cx, 'gcx, 'tcx> MirBorrowckCtxt<'cx, 'gcx, 'tcx> {
130130
);
131131

132132
let mut is_loop_move = false;
133+
let is_partial_move = move_site_vec.iter().any(|move_site| {
134+
let move_out = self.move_data.moves[(*move_site).moi];
135+
let moved_place = &self.move_data.move_paths[move_out.path].place;
136+
used_place != moved_place && used_place.is_prefix_of(moved_place)
137+
});
133138
for move_site in &move_site_vec {
134139
let move_out = self.move_data.moves[(*move_site).moi];
135140
let moved_place = &self.move_data.move_paths[move_out.path].place;
@@ -175,8 +180,9 @@ impl<'cx, 'gcx, 'tcx> MirBorrowckCtxt<'cx, 'gcx, 'tcx> {
175180
err.span_label(
176181
span,
177182
format!(
178-
"value {} here after move",
179-
desired_action.as_verb_in_past_tense()
183+
"value {} here {}",
184+
desired_action.as_verb_in_past_tense(),
185+
if is_partial_move { "after partial move" } else { "after move" },
180186
),
181187
);
182188
}

src/test/ui/borrowck/borrowck-uninit-field-access.mir.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ error[E0382]: use of moved value: `line2`
2020
LL | let _moved = (line2.origin, line2.middle);
2121
| ------------ value moved here
2222
LL | line2.consume(); //[ast]~ ERROR use of partially moved value: `line2` [E0382]
23-
| ^^^^^ value used here after move
23+
| ^^^^^ value used here after partial move
2424
|
2525
= note: move occurs because `line2.middle` has type `Point`, which does not implement the `Copy` trait
2626

src/test/ui/nll/move-subpaths-moves-root.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ error[E0382]: use of moved value: `x`
44
LL | drop(x.0);
55
| --- value moved here
66
LL | drop(x); //~ ERROR use of moved value
7-
| ^ value used here after move
7+
| ^ value used here after partial move
88
|
99
= note: move occurs because `x.0` has type `std::vec::Vec<i32>`, which does not implement the `Copy` trait
1010

0 commit comments

Comments
 (0)