-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate async-init pattern to network/Connection.ts
#293
Comments
It'd be important to revert some of the changes done to networking until a proper review @tegefaulkes |
The The |
After attempting to do this, asynchronous creation is going to be difficult for If seems making it |
So it's now |
Specification
The
network/Connection.ts
and derived classes are still using the old manual start booleans. These should have async-init applied as well. I recommend usingCreateDestroy
instead ofstart
stop
.Make sure to update
ForwardProxy
andReverseProxy
as well as the entire connection object lifecycle is managed by these 2.Because
Connection
is an abstract class, the pattern has to follow the same style asGRPCClient
. The static creation function instead creates parameters used to construct the derived classes.Additional context
Tasks
Connection
,ConnectionForward
,ConnectionReverse
and replace start/stop withCreateDestroy
patternForwardProxy
andReverseProxy
with the new create destroy patterns used byConnection
.network
tests are workingnodes
tests are workingThe text was updated successfully, but these errors were encountered: