Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/eng 557 create bundled config for common rules #8

Conversation

CDeltakai
Copy link
Contributor

Description

This PR implements a bundled config that includes all of the commonly used MatrixAI linting rules to streamline setting up linting in new repos.

Issues Fixed

Tasks

  • 1. Create a bundled config that implements all commonly used linting rules

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CDeltakai CDeltakai self-assigned this Mar 21, 2025
Copy link

linear bot commented Mar 21, 2025

ENG-557

@CMCDragonkai
Copy link
Member

@tegefaulkes how will this repo be used? Can we import it in every repo's eslint.config.mjs?

@tegefaulkes
Copy link
Contributor

Yeah, the idea is that we import it in all our projects and it provides 2 things.

  1. A collection of custom rules and configs that groups their configuration.
  2. Some extra configs which will contain our common rule config.

So when this is all done we just need to enable the recommended rules from this repo and it should provide all the rules we want without having to configure each repo separately.

This issue focuses on collecting all our common rules into a single config.

@CMCDragonkai this needs to be specced out better. You need to explain what the issue does, why we're doing it and how we're going to do it.

@CMCDragonkai
Copy link
Member

The feature branch here doesn't match the branch name pattern required.

@CDeltakai CDeltakai closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants