Skip to content

Commit 1a4d499

Browse files
ccharlyccharly
committed
refactor: move deps to devDeps for types + use peerDep for keyring-api
1 parent 29e1524 commit 1a4d499

File tree

7 files changed

+37
-45
lines changed

7 files changed

+37
-45
lines changed

‎packages/keyring-eth-trezor/package.json

+5-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@
5252
"@metamask/eth-sig-util": "^8.0.0",
5353
"@trezor/connect-plugin-ethereum": "^9.0.3",
5454
"@trezor/connect-web": "^9.1.11",
55-
"hdkey": "^2.1.0",
56-
"tslib": "^2.6.2"
55+
"hdkey": "^2.1.0"
5756
},
5857
"devDependencies": {
5958
"@ethereumjs/common": "^3.2.0",
@@ -76,9 +75,13 @@
7675
"sinon": "^19.0.2",
7776
"ts-jest": "^29.0.5",
7877
"ts-node": "^10.9.2",
78+
"tslib": "^2.6.2",
7979
"typedoc": "^0.25.13",
8080
"typescript": "~5.6.3"
8181
},
82+
"peerDependencies": {
83+
"tslib": "^2.6.2"
84+
},
8285
"engines": {
8386
"node": "^18.18 || >=20"
8487
},

‎packages/keyring-internal-api/package.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
"test:watch": "jest --watch"
4646
},
4747
"dependencies": {
48-
"@metamask/keyring-api": "workspace:^",
4948
"@metamask/keyring-utils": "workspace:^",
5049
"@metamask/superstruct": "^3.1.0",
5150
"@metamask/utils": "^9.3.0"
@@ -68,6 +67,9 @@
6867
"typedoc": "^0.25.13",
6968
"typescript": "~5.6.3"
7069
},
70+
"peerDependencies": {
71+
"@metamask/keyring-api": "workspace:^"
72+
},
7173
"engines": {
7274
"node": "^18.18 || >=20"
7375
},

‎packages/keyring-internal-snap-client/package.json

+5-6
Original file line numberDiff line numberDiff line change
@@ -45,19 +45,18 @@
4545
"test:watch": "jest --watch"
4646
},
4747
"dependencies": {
48-
"@metamask/keyring-api": "workspace:^",
4948
"@metamask/keyring-snap-client": "workspace:^",
5049
"@metamask/keyring-utils": "workspace:^",
51-
"@metamask/snaps-controllers": "^9.10.0",
52-
"@metamask/snaps-sdk": "^6.7.0",
53-
"@metamask/snaps-utils": "^8.3.0",
5450
"webextension-polyfill": "^0.12.0"
5551
},
5652
"devDependencies": {
5753
"@lavamoat/allow-scripts": "^3.2.1",
5854
"@lavamoat/preinstall-always-fail": "^2.1.0",
5955
"@metamask/auto-changelog": "^3.4.4",
60-
"@metamask/providers": "^18.1.0",
56+
"@metamask/keyring-api": "workspace:^",
57+
"@metamask/snaps-controllers": "^9.10.0",
58+
"@metamask/snaps-sdk": "^6.7.0",
59+
"@metamask/snaps-utils": "^8.3.0",
6160
"@metamask/utils": "^9.3.0",
6261
"@ts-bridge/cli": "^0.6.1",
6362
"@types/jest": "^29.5.12",
@@ -74,7 +73,7 @@
7473
"typescript": "~5.6.3"
7574
},
7675
"peerDependencies": {
77-
"@metamask/providers": "^18.1.0"
76+
"@metamask/keyring-api": "workspace:^"
7877
},
7978
"engines": {
8079
"node": "^18.18 || >=20"

‎packages/keyring-snap-bridge/package.json

+6-9
Original file line numberDiff line numberDiff line change
@@ -39,26 +39,22 @@
3939
"dependencies": {
4040
"@ethereumjs/tx": "^4.2.0",
4141
"@metamask/eth-sig-util": "^8.0.0",
42-
"@metamask/keyring-api": "workspace:^",
43-
"@metamask/keyring-internal-api": "workspace:^",
44-
"@metamask/keyring-internal-snap-client": "workspace:^",
45-
"@metamask/snaps-controllers": "^9.10.0",
46-
"@metamask/snaps-sdk": "^6.7.0",
47-
"@metamask/snaps-utils": "^8.3.0",
4842
"@metamask/superstruct": "^3.1.0",
4943
"@metamask/utils": "^9.3.0",
50-
"@types/uuid": "^9.0.8",
5144
"uuid": "^9.0.1",
5245
"webextension-polyfill": "^0.12.0"
5346
},
5447
"devDependencies": {
5548
"@lavamoat/allow-scripts": "^3.2.1",
5649
"@lavamoat/preinstall-always-fail": "^2.1.0",
5750
"@metamask/auto-changelog": "^3.4.4",
58-
"@metamask/providers": "^18.1.0",
51+
"@metamask/snaps-controllers": "^9.10.0",
52+
"@metamask/snaps-sdk": "^6.7.0",
53+
"@metamask/snaps-utils": "^8.3.0",
5954
"@ts-bridge/cli": "^0.6.1",
6055
"@types/jest": "^29.5.12",
6156
"@types/node": "^20.12.12",
57+
"@types/uuid": "^9.0.8",
6258
"deepmerge": "^4.2.2",
6359
"depcheck": "^1.4.7",
6460
"jest": "^29.5.0",
@@ -71,7 +67,8 @@
7167
},
7268
"peerDependencies": {
7369
"@metamask/keyring-api": "workspace:^",
74-
"@metamask/providers": "^18.1.0"
70+
"@metamask/keyring-internal-api": "workspace:^",
71+
"@metamask/keyring-internal-snap-client": "workspace:^"
7572
},
7673
"engines": {
7774
"node": "^18.18 || >=20"

‎packages/keyring-snap-client/package.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,10 @@
4545
"test:watch": "jest --watch"
4646
},
4747
"dependencies": {
48-
"@metamask/keyring-api": "workspace:^",
4948
"@metamask/keyring-utils": "workspace:^",
5049
"@metamask/superstruct": "^3.1.0",
5150
"@types/uuid": "^9.0.8",
52-
"uuid": "^9.0.1",
53-
"webextension-polyfill": "^0.12.0"
51+
"uuid": "^9.0.1"
5452
},
5553
"devDependencies": {
5654
"@lavamoat/allow-scripts": "^3.2.1",
@@ -73,7 +71,7 @@
7371
"typescript": "~5.6.3"
7472
},
7573
"peerDependencies": {
76-
"@metamask/providers": "^18.1.0"
74+
"@metamask/keyring-api": "workspace:^"
7775
},
7876
"engines": {
7977
"node": "^18.18 || >=20"

‎packages/keyring-snap-sdk/package.json

+5-7
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,14 @@
4646
},
4747
"dependencies": {
4848
"@metamask/keyring-utils": "workspace:^",
49-
"@metamask/snaps-sdk": "^6.7.0",
5049
"@metamask/superstruct": "^3.1.0",
51-
"@metamask/utils": "^9.3.0",
52-
"webextension-polyfill": "^0.12.0"
50+
"@metamask/utils": "^9.3.0"
5351
},
5452
"devDependencies": {
5553
"@lavamoat/allow-scripts": "^3.2.1",
5654
"@lavamoat/preinstall-always-fail": "^2.1.0",
5755
"@metamask/auto-changelog": "^3.4.4",
58-
"@metamask/keyring-api": "workspace:^",
59-
"@metamask/providers": "^18.1.0",
56+
"@metamask/snaps-sdk": "^6.7.0",
6057
"@ts-bridge/cli": "^0.6.1",
6158
"@types/jest": "^29.5.12",
6259
"@types/node": "^20.12.12",
@@ -69,10 +66,11 @@
6966
"ts-node": "^10.9.2",
7067
"tsd": "^0.31.0",
7168
"typedoc": "^0.25.13",
72-
"typescript": "~5.6.3"
69+
"typescript": "~5.6.3",
70+
"webextension-polyfill": "^0.12.0"
7371
},
7472
"peerDependencies": {
75-
"@metamask/providers": "^18.1.0"
73+
"@metamask/keyring-api": "workspace:^"
7674
},
7775
"engines": {
7876
"node": "^18.18 || >=20"

‎yarn.lock

+11-16
Original file line numberDiff line numberDiff line change
@@ -1998,10 +1998,6 @@ __metadata:
19981998
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
19991999
"@metamask/auto-changelog": "npm:^3.4.4"
20002000
"@metamask/eth-sig-util": "npm:^8.0.0"
2001-
"@metamask/keyring-api": "workspace:^"
2002-
"@metamask/keyring-internal-api": "workspace:^"
2003-
"@metamask/keyring-internal-snap-client": "workspace:^"
2004-
"@metamask/providers": "npm:^18.1.0"
20052001
"@metamask/snaps-controllers": "npm:^9.10.0"
20062002
"@metamask/snaps-sdk": "npm:^6.7.0"
20072003
"@metamask/snaps-utils": "npm:^8.3.0"
@@ -2024,7 +2020,8 @@ __metadata:
20242020
webextension-polyfill: "npm:^0.12.0"
20252021
peerDependencies:
20262022
"@metamask/keyring-api": "workspace:^"
2027-
"@metamask/providers": ^18.1.0
2023+
"@metamask/keyring-internal-api": "workspace:^"
2024+
"@metamask/keyring-internal-snap-client": "workspace:^"
20282025
languageName: unknown
20292026
linkType: soft
20302027

@@ -2061,6 +2058,8 @@ __metadata:
20612058
tslib: "npm:^2.6.2"
20622059
typedoc: "npm:^0.25.13"
20632060
typescript: "npm:~5.6.3"
2061+
peerDependencies:
2062+
tslib: ^2.6.2
20642063
languageName: unknown
20652064
linkType: soft
20662065

@@ -2163,14 +2162,13 @@ __metadata:
21632162
languageName: unknown
21642163
linkType: soft
21652164

2166-
"@metamask/keyring-internal-api@workspace:^, @metamask/keyring-internal-api@workspace:packages/keyring-internal-api":
2165+
"@metamask/keyring-internal-api@workspace:packages/keyring-internal-api":
21672166
version: 0.0.0-use.local
21682167
resolution: "@metamask/keyring-internal-api@workspace:packages/keyring-internal-api"
21692168
dependencies:
21702169
"@lavamoat/allow-scripts": "npm:^3.2.1"
21712170
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
21722171
"@metamask/auto-changelog": "npm:^3.4.4"
2173-
"@metamask/keyring-api": "workspace:^"
21742172
"@metamask/keyring-utils": "workspace:^"
21752173
"@metamask/superstruct": "npm:^3.1.0"
21762174
"@metamask/utils": "npm:^9.3.0"
@@ -2187,10 +2185,12 @@ __metadata:
21872185
tsd: "npm:^0.31.0"
21882186
typedoc: "npm:^0.25.13"
21892187
typescript: "npm:~5.6.3"
2188+
peerDependencies:
2189+
"@metamask/keyring-api": "workspace:^"
21902190
languageName: unknown
21912191
linkType: soft
21922192

2193-
"@metamask/keyring-internal-snap-client@workspace:^, @metamask/keyring-internal-snap-client@workspace:packages/keyring-internal-snap-client":
2193+
"@metamask/keyring-internal-snap-client@workspace:packages/keyring-internal-snap-client":
21942194
version: 0.0.0-use.local
21952195
resolution: "@metamask/keyring-internal-snap-client@workspace:packages/keyring-internal-snap-client"
21962196
dependencies:
@@ -2200,7 +2200,6 @@ __metadata:
22002200
"@metamask/keyring-api": "workspace:^"
22012201
"@metamask/keyring-snap-client": "workspace:^"
22022202
"@metamask/keyring-utils": "workspace:^"
2203-
"@metamask/providers": "npm:^18.1.0"
22042203
"@metamask/snaps-controllers": "npm:^9.10.0"
22052204
"@metamask/snaps-sdk": "npm:^6.7.0"
22062205
"@metamask/snaps-utils": "npm:^8.3.0"
@@ -2220,7 +2219,7 @@ __metadata:
22202219
typescript: "npm:~5.6.3"
22212220
webextension-polyfill: "npm:^0.12.0"
22222221
peerDependencies:
2223-
"@metamask/providers": ^18.1.0
2222+
"@metamask/keyring-api": "workspace:^"
22242223
languageName: unknown
22252224
linkType: soft
22262225

@@ -2231,7 +2230,6 @@ __metadata:
22312230
"@lavamoat/allow-scripts": "npm:^3.2.1"
22322231
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
22332232
"@metamask/auto-changelog": "npm:^3.4.4"
2234-
"@metamask/keyring-api": "workspace:^"
22352233
"@metamask/keyring-utils": "workspace:^"
22362234
"@metamask/providers": "npm:^18.1.0"
22372235
"@metamask/superstruct": "npm:^3.1.0"
@@ -2251,9 +2249,8 @@ __metadata:
22512249
typedoc: "npm:^0.25.13"
22522250
typescript: "npm:~5.6.3"
22532251
uuid: "npm:^9.0.1"
2254-
webextension-polyfill: "npm:^0.12.0"
22552252
peerDependencies:
2256-
"@metamask/providers": ^18.1.0
2253+
"@metamask/keyring-api": "workspace:^"
22572254
languageName: unknown
22582255
linkType: soft
22592256

@@ -2264,9 +2261,7 @@ __metadata:
22642261
"@lavamoat/allow-scripts": "npm:^3.2.1"
22652262
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
22662263
"@metamask/auto-changelog": "npm:^3.4.4"
2267-
"@metamask/keyring-api": "workspace:^"
22682264
"@metamask/keyring-utils": "workspace:^"
2269-
"@metamask/providers": "npm:^18.1.0"
22702265
"@metamask/snaps-sdk": "npm:^6.7.0"
22712266
"@metamask/superstruct": "npm:^3.1.0"
22722267
"@metamask/utils": "npm:^9.3.0"
@@ -2285,7 +2280,7 @@ __metadata:
22852280
typescript: "npm:~5.6.3"
22862281
webextension-polyfill: "npm:^0.12.0"
22872282
peerDependencies:
2288-
"@metamask/providers": ^18.1.0
2283+
"@metamask/keyring-api": "workspace:^"
22892284
languageName: unknown
22902285
linkType: soft
22912286

0 commit comments

Comments
 (0)