Crash when using --systems i686-linux

[Jayman2000]

Steps to Reproduce

1. Make sure that your current system is either i686-linux or x86_64-linux.

2. Make sure that you have a local clone of the Nixpkgs repo.

3. Change directory into that local clone of the Nixpkgs repo by running this command:

   cd <path-to-nixpkgs-repo>

4. Attempt to have nixpkgs-review build packages for i686-linux by running this command:

   nix --extra-experimental-features 'nix-command flakes' run github:Mic92/nixpkgs-review  -- pr --systems i686-linux 372642

Results

$ nix-instantiate --eval --expr builtins.currentSystem
"x86_64-linux"
$ cd .
$ nix --extra-experimental-features 'nix-command flakes' run github:Mic92/nixpkgs-review  -- pr --systems i686-linux 372642
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs release-24.11:refs/nixpkgs-review/0 pull/372642/merge:refs/nixpkgs-review/1
$ git worktree add /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs 362878b5cb7e44a2de012b4fe6ade4649f9b8f0e
Preparing worktree (detached HEAD 362878b5cb7e)
Updating files: 100% (44422/44422), done.
HEAD is now at 362878b5cb7e arouteserver: disable copyright year test (#372622)
Local evaluation for computing rebuilds
$ nix-env --extra-experimental-features no-url-literals --option system i686-linux -f <nixpkgs> --nix-path nixpkgs=/home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs nixpkgs-overlays=/tmp/tmpmrr9o10f -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
error:
       … while evaluating the attribute 'vscode-extensions'
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/pkgs/top-level/all-packages.nix:16219:3:
        16218|
        16219|   vscode-extensions = recurseIntoAttrs (callPackage ../applications/editors/vscode/extensions { });
             |   ^
        16220|

       … while evaluating the attribute 'continue'

       … while evaluating the attribute 'continue'
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/pkgs/applications/editors/vscode/extensions/default.nix:1046:7:
         1045|
         1046|       continue.continue = buildVscodeMarketplaceExtension {
             |       ^
         1047|         mktplcRef =

       … while evaluating the 'name' attribute of a derivation

       … from call site
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:354:9:
          353|         in
          354|         lib.strings.sanitizeDerivationName (
             |         ^
          355|           if attrs ? name

       … while calling anonymous lambda
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/lib/strings.nix:2625:3:
         2624|   in
         2625|   string:
             |   ^
         2626|   # First detect the common case of already valid strings, to speed those up

       … while evaluating a branch condition
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/lib/strings.nix:2627:3:
         2626|   # First detect the common case of already valid strings, to speed those up
         2627|   if stringLength string <= 207 && okRegex string != null
             |   ^
         2628|   then unsafeDiscardStringContext string

       … in the left operand of the AND (&&) operator
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/lib/strings.nix:2627:33:
         2626|   # First detect the common case of already valid strings, to speed those up
         2627|   if stringLength string <= 207 && okRegex string != null
             |                                 ^
         2628|   then unsafeDiscardStringContext string

       … in the argument of the not operator
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/lib/strings.nix:2627:26:
         2626|   # First detect the common case of already valid strings, to speed those up
         2627|   if stringLength string <= 207 && okRegex string != null
             |                          ^
         2628|   then unsafeDiscardStringContext string

       … while calling the 'lessThan' builtin
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/lib/strings.nix:2627:26:
         2626|   # First detect the common case of already valid strings, to speed those up
         2627|   if stringLength string <= 207 && okRegex string != null
             |                          ^
         2628|   then unsafeDiscardStringContext string

       … while calling the 'stringLength' builtin
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/lib/strings.nix:2627:6:
         2626|   # First detect the common case of already valid strings, to speed those up
         2627|   if stringLength string <= 207 && okRegex string != null
             |      ^
         2628|   then unsafeDiscardStringContext string

       … while evaluating the attribute 'name'
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/pkgs/applications/editors/vscode/extensions/vscode-utils.nix:39:9:
           38|
           39|         name = "vscode-extension-${name}";
             |         ^
           40|

       … in the right operand of the update (//) operator
         at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/pkgs/applications/editors/vscode/extensions/default.nix:1073:11:
         1072|           }
         1073|           // sources.${stdenv.system};
             |           ^
         1074|         nativeBuildInputs = lib.optionals stdenv.hostPlatform.isLinux [ autoPatchelfHook ];

       error: attribute 'i686-linux' missing
       at /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs/pkgs/applications/editors/vscode/extensions/default.nix:1073:14:
         1072|           }
         1073|           // sources.${stdenv.system};
             |              ^
         1074|         nativeBuildInputs = lib.optionals stdenv.hostPlatform.isLinux [ autoPatchelfHook ];
https://github.com/NixOS/nixpkgs/pull/372642 failed to build: Failed to list packages: nix-env failed with exit code 1
$ git worktree remove -f /home/jayman/.cache/nixpkgs-review/pr-372642-5/nixpkgs
$ echo "$?"
1
$ 

[Mic92]

Well. This is a nixpkgs issue, we can fix this in nixpkgs-review. This vscode extensions should do a sources.${stdenv.system} or throw "unsupported system ${stdenv.system}" instead.